From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, Pekka Sarnila <sarnila@adit.fi>
Subject: Re: [PATCH 1/1] HID: ignore afatech 9016
Date: Wed, 13 Jan 2010 21:34:16 +0100 [thread overview]
Message-ID: <4B4E2E48.1000509@gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1001132111570.30977@pobox.suse.cz>
On 01/13/2010 09:20 PM, Jiri Kosina wrote:
>> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
>> index 38773dc..788d9a3 100644
>> --- a/drivers/hid/usbhid/hid-quirks.c
>> +++ b/drivers/hid/usbhid/hid-quirks.c
>> @@ -41,7 +41,7 @@ static const struct hid_blacklist {
>> { USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RUMBLEPAD, HID_QUIRK_BADPAD },
>> { USB_VENDOR_ID_TOPMAX, USB_DEVICE_ID_TOPMAX_COBRAPAD, HID_QUIRK_BADPAD },
>>
>> - { USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016, HID_QUIRK_FULLSPEED_INTERVAL },
>> + { USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016, HID_QUIRK_IGNORE },
>
> Hmm, why do we keep HID_QUIRK_IGNORE anyway, when we already have generic
> hid_ignore_list[]?
You returned it back because of dynamic quirks...
> We don't set it for any device in the current codebase any more.
Oh yeah, it's hard for people who don't remember code they wrote :).
Will respin. Thanks for the reminder.
--
js
next prev parent reply other threads:[~2010-01-13 20:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 19:59 [PATCH 1/1] HID: ignore afatech 9016 Jiri Slaby
2010-01-13 20:20 ` Jiri Kosina
2010-01-13 20:34 ` Jiri Slaby [this message]
2010-01-13 20:44 ` Jiri Kosina
2010-01-13 20:39 ` [PATCH v2 " Jiri Slaby
2010-01-26 0:56 ` Jiri Kosina
2010-01-26 11:06 ` Pekka Sarnila
[not found] ` <4B5EFD69.4080802@adit.fi>
[not found] ` <alpine.LNX.2.00.1001262344200.30977@pobox.suse.cz>
[not found] ` <4B671C31.3040902@qvantel.com>
[not found] ` <alpine.LNX.2.00.1002011928220.15395@pobox.suse.cz>
2010-02-01 19:42 ` dvb-usb-remote woes [was: HID: ignore afatech 9016] Jiri Slaby
2010-02-01 21:23 ` Antti Palosaari
2010-02-01 21:41 ` Jiri Slaby
2010-02-02 16:16 ` Pekka Sarnila
2010-02-02 15:54 ` Pekka Sarnila
2010-02-02 16:02 ` Pekka Sarnila
2010-02-05 15:47 ` Pekka Sarnila
2010-02-08 15:52 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4E2E48.1000509@gmail.com \
--to=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sarnila@adit.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.