From: Nishanth Menon <nm@ti.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 3/9] omap: generic: introduce a single check_revision
Date: Fri, 25 Jun 2010 08:18:33 -0500 [thread overview]
Message-ID: <4C24ACA9.3040505@ti.com> (raw)
In-Reply-To: <AANLkTikivRbnADYMUJtzAEbjQt6yCNJLvq66tTIfcmnK@mail.gmail.com>
Grazvydas Ignotas had written, on 06/25/2010 04:31 AM, the following:
> On Wed, Jun 23, 2010 at 5:16 AM, Nishanth Menon <nm@ti.com> wrote:
>> Introduce a single omap generic check_revision that routes the
>> request to the right revision of check_revision.
[...]
>
>> diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c
>> index fca73cd..538e170 100644
>> --- a/arch/arm/plat-omap/common.c
>> +++ b/arch/arm/plat-omap/common.c
>> @@ -89,6 +89,18 @@ void __init omap_reserve(void)
>> omap_vram_reserve_sdram_lmb();
>> }
>>
>> +void __init omap_check_revision()
>
> minor nitpick:
> void __init omap_check_revision(void)?
ack. thanks for catching this.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-06-25 13:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 2:16 [PATCH 0/9 v2] introduce generic OMAP SOC features Nishanth Menon
2010-06-23 2:16 ` [PATCH 1/9] omap1: rename check_revision Nishanth Menon
2010-06-23 2:16 ` [PATCH 2/9] omap2/3: id: fix sparse warning Nishanth Menon
2010-06-23 2:16 ` [PATCH 3/9] omap: generic: introduce a single check_revision Nishanth Menon
2010-06-25 9:31 ` Grazvydas Ignotas
2010-06-25 13:18 ` Nishanth Menon [this message]
2010-06-23 2:16 ` [PATCH 4/9] omap: improve OMAP3_HAS_FEATURE Nishanth Menon
2010-07-07 12:28 ` Tony Lindgren
2010-07-07 13:15 ` Nishanth Menon
2010-07-07 13:30 ` Tony Lindgren
2010-07-07 13:50 ` Nishanth Menon
2010-07-08 9:24 ` Tony Lindgren
2010-06-23 2:16 ` [PATCH 5/9] omap: introduce OMAP_SHOW_FEATURE Nishanth Menon
2010-06-23 2:16 ` [PATCH 6/9] omap: move generic omap3 features to generic Nishanth Menon
2010-07-07 12:30 ` Tony Lindgren
2010-06-23 2:16 ` [PATCH 7/9] omap: introduce omap4 feature Nishanth Menon
2010-06-23 2:16 ` [PATCH 8/9] omap: introduce omap24xx generic features Nishanth Menon
2010-06-23 2:16 ` [PATCH 9/9] omap: id: add feature check for omap1 Nishanth Menon
2010-07-06 12:46 ` Tony Lindgren
2010-07-06 12:53 ` Nishanth Menon
2010-07-06 13:14 ` Tony Lindgren
2010-07-06 16:07 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C24ACA9.3040505@ti.com \
--to=nm@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.