From: Bernhard Walle <walle@corscience.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: dbrownell@users.sourceforge.net, grant.likely@secretlab.ca,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] spi: spidev: Add 32 bit compat ioctl()
Date: Wed, 02 Feb 2011 12:32:48 +0100 [thread overview]
Message-ID: <4D4940E0.8070306@corscience.de> (raw)
In-Reply-To: <201102021215.29002.arnd@arndb.de>
Am 02.02.2011 12:15, schrieb Arnd Bergmann:
> On Wednesday 02 February 2011, Bernhard Walle wrote:
>> Add the compat_ioctl for operations on /dev/spi* so that 32 bit
>> userspace applications can access SPI. As far as I can see all data
>> structure are already prepared for that, so no additional conversion has
>> to be done.
>>
>> My use case is MIPS with N32 userspace ABI and toolchain, and that was
>> also the platform where I tested it successfully (Cavium Octeon).
>>
>> Signed-off-by: Bernhard Walle <walle@corscience.de>
>
> I think you now need to #include <linux/compat.h> as well, to get the
> definition of compat_ptr(). Otherwise looks good.
It compiled on my MIPS test environment without that include, but I
adjusted the patch and posted again.
Thanks for reviewing, Arnd!
Regards,
Bernhard
next prev parent reply other threads:[~2011-02-02 11:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 10:57 [PATCH] spi: spidev: Add 32 bit compat ioctl() Bernhard Walle
2011-02-02 11:15 ` Arnd Bergmann
2011-02-02 11:32 ` Bernhard Walle [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-03 8:37 Bernhard Walle
2011-02-03 16:56 ` Grant Likely
2011-02-02 11:31 Bernhard Walle
2011-02-02 12:18 ` Arnd Bergmann
2011-02-02 14:15 ` Grant Likely
2011-02-03 8:38 ` Bernhard Walle
2011-02-02 11:30 Bernhard Walle
2011-02-02 10:56 Unknown, y
2011-02-02 10:56 y
2011-02-02 10:56 y
2011-02-01 9:02 Bernhard Walle
2011-02-02 4:39 ` Grant Likely
2011-02-02 9:37 ` Arnd Bergmann
2011-02-02 10:56 ` Bernhard Walle
2011-02-02 14:12 ` Grant Likely
2011-01-11 15:32 Bernhard Walle
2010-12-01 10:51 Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4940E0.8070306@corscience.de \
--to=walle@corscience.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.