All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rlandley@parallels.com>
To: <linux-nfs@vger.kernel.org>
Subject: CACHE_NEW_EXPIRY is 120, nextcheck initialized to 30*60=1800?
Date: Tue, 22 Feb 2011 07:31:12 -0600	[thread overview]
Message-ID: <4D63BAA0.3090505@parallels.com> (raw)

In net/sunrpc/cache.c line 416 or so (function cache_clean()) there's
this bit:

else {
        current_index = 0;
        current_detail->nextcheck = seconds_since_boot()+30*60;
}

The other uses of seconds_since_boot() add CACHE_NEW_EXPIRY (which is
120).  This is A) more than ten times that, B) a magic inline constant.

Is there a reason for this?  (Some subtle cache lifetime balancing thing?)

Rob

             reply	other threads:[~2011-02-22 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 13:31 Rob Landley [this message]
2011-02-22 21:07 ` CACHE_NEW_EXPIRY is 120, nextcheck initialized to 30*60=1800? NeilBrown
2011-02-23  3:59   ` Rob Landley
2011-02-23  5:53     ` NeilBrown
2011-02-23 19:27       ` NFS in containers Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D63BAA0.3090505@parallels.com \
    --to=rlandley@parallels.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.