From: "R, Durgadoss" <durgadoss.r@intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>, "lenb@kernel.org" <lenb@kernel.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"eduardo.valentin@ti.com" <eduardo.valentin@ti.com>
Subject: RE: [PATCHv2 06/14] Thermal: Add a policy sysfs attribute
Date: Mon, 27 Aug 2012 10:25:58 +0000 [thread overview]
Message-ID: <4D68720C2E767A4AA6A8796D42C8EB591AD665@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <744357E9AAD1214791ACBA4B0B90926321026B@SHSMSX101.ccr.corp.intel.com>
> > +static ssize_t
> > +policy_show(struct device *dev, struct device_attribute *devattr, char
> > +*buf) {
> > + struct thermal_zone_device *tz = to_thermal_zone(dev);
> > + struct thermal_zone_params *tzp = tz->tzp;
> > +
> > + if (!tzp)
> > + return sprintf(buf, "step_wise(default)\n");
> > +
> > + switch (tzp->throttle_policy) {
> > + case THERMAL_FAIR_SHARE:
> > + return sprintf(buf, "fair_share\n");
> > + case THERMAL_STEP_WISE:
> > + return sprintf(buf, "step_wise\n");
> > + case THERMAL_USER_SPACE:
> > + return sprintf(buf, "user_space\n");
> > + default:
> > + return sprintf(buf, "unknown\n");
> > + }
> > +}
> > +
> > static DEVICE_ATTR(type, 0444, type_show, NULL); static
> > DEVICE_ATTR(temp, 0444, temp_show, NULL); static DEVICE_ATTR(mode,
> > 0644, mode_show, mode_store); static DEVICE_ATTR(passive, S_IRUGO |
> > S_IWUSR, passive_show, passive_store);
> > +static DEVICE_ATTR(throttle_policy, S_IRUGO, policy_show, NULL);
> >
> > /* sys I/F for cooling device */
> > #define to_cooling_device(_dev) \
> > @@ -1349,10 +1371,16 @@ static int retrieve_zone_params(struct
> > thermal_zone_device *tz)
> >
> > /* It is not an error to not have any platform data */
> > ret = get_platform_thermal_params(tz);
> > - if (ret)
> > + if (ret) {
> > tz->tzp = NULL;
> > + return 0;
> > + }
> >
> > - return 0;
> > + ret = device_create_file(&tz->device, &dev_attr_throttle_policy);
> > + if (ret)
> > + dev_err(&tz->device, "creating policy attr failed:%d\n",
> > ret);
> > +
> > + return ret;
> > }
> >
> > /**
>
> We should remove this attribute in thermal_zone_device_unregister();
Oh yes, missed it :-(
Will fix in v3..
Thanks for the catch,
Durga
next prev parent reply other threads:[~2012-08-27 10:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 4:28 [PATCHv2 00/14] Thermal Framework Enhancements Durgadoss R
2012-08-27 4:28 ` [PATCHv2 01/14] Thermal: Refactor thermal.h file Durgadoss R
2012-08-27 4:28 ` [PATCHv2 02/14] Thermal: Move thermal_instance to thermal_core.h Durgadoss R
2012-08-27 4:28 ` [PATCHv2 03/14] Thermal: Add get trend, get instance API's to thermal_sys Durgadoss R
2012-08-27 8:11 ` Zhang, Rui
2012-08-27 8:47 ` R, Durgadoss
2012-08-27 9:19 ` Zhang, Rui
2012-08-27 9:24 ` R, Durgadoss
2012-08-27 4:28 ` [PATCHv2 04/14] Thermal: Add platform level information to thermal.h Durgadoss R
2012-08-27 8:27 ` Zhang, Rui
2012-08-27 8:57 ` R, Durgadoss
2012-08-27 9:22 ` Zhang, Rui
2012-08-27 9:25 ` R, Durgadoss
2012-08-27 4:28 ` [PATCHv2 05/14] Thermal: Obtain platform data for thermal zone Durgadoss R
2012-08-27 8:29 ` Zhang, Rui
2012-08-27 8:59 ` R, Durgadoss
2012-08-27 4:28 ` [PATCHv2 06/14] Thermal: Add a policy sysfs attribute Durgadoss R
2012-08-27 8:31 ` Zhang, Rui
2012-08-27 9:02 ` R, Durgadoss
2012-08-27 9:25 ` Zhang, Rui
2012-08-27 10:23 ` R, Durgadoss
2012-08-27 10:44 ` Zhang, Rui
2012-08-27 9:35 ` Zhang, Rui
2012-08-27 10:25 ` R, Durgadoss [this message]
2012-08-27 4:28 ` [PATCHv2 07/14] Thermal: Update binding logic based on platform data Durgadoss R
2012-08-27 9:50 ` Zhang, Rui
2012-08-27 10:29 ` R, Durgadoss
2012-08-27 4:28 ` [PATCHv2 08/14] Thermal: Make thermal_cdev_update as a global function Durgadoss R
2012-08-27 4:28 ` [PATCHv2 09/14] Thermal: Introduce fair_share thermal governor Durgadoss R
2012-08-27 4:28 ` [PATCHv2 10/14] Thermal: Introduce a step_wise " Durgadoss R
2012-08-27 4:28 ` [PATCHv2 11/14] Thermal: Remove throttling logic out of thermal_sys.c Durgadoss R
2012-08-27 4:28 ` [PATCHv2 12/14] Thermal: Add a notification API Durgadoss R
2012-08-27 4:28 ` [PATCHv2 13/14] Thermal: Add documentation for platform layer data Durgadoss R
2012-08-27 4:28 ` [PATCHv2 14/14] Thermal: Platform layer changes to provide thermal data Durgadoss R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D68720C2E767A4AA6A8796D42C8EB591AD665@BGSMSX101.gar.corp.intel.com \
--to=durgadoss.r@intel.com \
--cc=eduardo.valentin@ti.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.