From: "R, Durgadoss" <durgadoss.r@intel.com>
To: Eduardo Valentin <eduardo.valentin@ti.com>,
"Zhang, Rui" <rui.zhang@intel.com>
Cc: "linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH RESEND 3/4] thermal: cleanup: use dev_* helper functions
Date: Wed, 2 Jan 2013 15:51:18 +0000 [thread overview]
Message-ID: <4D68720C2E767A4AA6A8796D42C8EB59252E4B@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <1357140582-8151-4-git-send-email-eduardo.valentin@ti.com>
> -----Original Message-----
> From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
> owner@vger.kernel.org] On Behalf Of Eduardo Valentin
> Sent: Wednesday, January 02, 2013 9:00 PM
> To: Zhang, Rui
> Cc: R, Durgadoss; linux-pm@lists.linux-foundation.org; linux-
> pm@vger.kernel.org; Eduardo Valentin
> Subject: [PATCH RESEND 3/4] thermal: cleanup: use dev_* helper functions
>
> Change the logging messages to used dev_* helper functions.
A good to have Change :-)
>
Reviewed-by: Durgadoss R <durgadoss.r@intel.com>
Thanks,
Durga
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/thermal/thermal_sys.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 70ce100..fba27c3 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -354,8 +354,9 @@ static void handle_critical_trips(struct
> thermal_zone_device *tz,
> tz->ops->notify(tz, trip, trip_type);
>
> if (trip_type == THERMAL_TRIP_CRITICAL) {
> - pr_emerg("Critical temperature reached(%d C),shutting
> down\n",
> - tz->temperature / 1000);
> + dev_emerg(&tz->device,
> + "critical temperature reached(%d C),shutting
> down\n",
> + tz->temperature / 1000);
> orderly_poweroff(true);
> }
> }
> @@ -386,7 +387,8 @@ static void update_temperature(struct
> thermal_zone_device *tz)
>
> ret = tz->ops->get_temp(tz, &temp);
> if (ret) {
> - pr_warn("failed to read out thermal zone %d\n", tz->id);
> + dev_warn(&tz->device, "failed to read out thermal zone
> %d\n",
> + tz->id);
> goto exit;
> }
>
> @@ -1770,7 +1772,7 @@ int thermal_generate_netlink_event(struct
> thermal_zone_device *tz,
>
> result = genlmsg_multicast(skb, 0, thermal_event_mcgrp.id,
> GFP_ATOMIC);
> if (result)
> - pr_info("failed to send netlink event:%d\n", result);
> + dev_err(&tz->device, "Failed to send netlink event:%d",
> result);
>
> return result;
> }
> --
> 1.7.7.1.488.ge8e1c
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-02 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 15:29 [PATCH RESEND 0/4] thermal sys: couple of fixes and cleanups Eduardo Valentin
2013-01-02 15:29 ` [PATCH RESEND 1/4] thermal: Use thermal zone device id in netlink messages Eduardo Valentin
2013-01-02 15:48 ` R, Durgadoss
2013-01-02 15:55 ` Eduardo Valentin
2013-01-16 2:43 ` Zhang Rui
2013-01-02 15:29 ` [PATCH RESEND 2/4] thermal: remove unnecessary include Eduardo Valentin
2013-01-02 15:48 ` R, Durgadoss
2013-01-16 2:43 ` Zhang Rui
2013-01-02 15:29 ` [PATCH RESEND 3/4] thermal: cleanup: use dev_* helper functions Eduardo Valentin
2013-01-02 15:51 ` R, Durgadoss [this message]
2013-01-16 2:44 ` Zhang Rui
2013-01-02 15:29 ` [PATCH RESEND 4/4] thermal: check for invalid trip setup when registering thermal device Eduardo Valentin
2013-01-02 15:53 ` R, Durgadoss
2013-01-16 2:45 ` Zhang Rui
2013-01-16 14:22 ` Eduardo Valentin
2013-01-17 7:10 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D68720C2E767A4AA6A8796D42C8EB59252E4B@BGSMSX101.gar.corp.intel.com \
--to=durgadoss.r@intel.com \
--cc=eduardo.valentin@ti.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.