From: Bryan Schumaker <bjschuma@netapp.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] NFSD: added FREE_STATEID operation
Date: Tue, 31 May 2011 10:52:09 -0400 [thread overview]
Message-ID: <4DE50099.6090901@netapp.com> (raw)
In-Reply-To: <20110525150510.GB11166@fieldses.org>
On 05/25/2011 11:05 AM, J. Bruce Fields wrote:
> On Fri, May 20, 2011 at 04:16:18PM -0400, Bryan Schumaker wrote:
>> On 05/20/2011 04:12 PM, bjschuma@netapp.com wrote:
>>> From: Bryan Schumaker <bjschuma@netapp.com>
>>> +static __be32
>>> +nfsd4_free_delegation_stateid(stateid_t *stateid)
>>> +{
>>> + struct nfs4_delegation *dp = search_for_delegation(stateid);
>>> + if (dp)
>>> + return nfserr_locks_held;
>>> + return nfserr_bad_stateid;
>>> +}
>>> +
>>> +static __be32
>>> +nfsd4_free_lock_stateid(stateid_t *stateid, struct nfs4_stateid *stp)
>>> +{
>>> + if (check_for_locks(stp->st_file, stp->st_stateowner))
>>
>> I'm not sure if stateids are unique to (file, stateowner), but I'm not sure how else to check for locks at the moment.
>
> Actually, looking... there's a one-to-one lockowner<->lockstateid
> correspondance. Which is dumb.
>
> The server's handling of lock state needs more serious help than I
> realized!
>
> I think your patch is OK now, though.
Thanks for the reviews!
>
> --b.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-31 14:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 20:12 [PATCH v2 0/2] NFSD: add FREE_STATEID and TEST_STATEID operations bjschuma
2011-05-20 20:12 ` [PATCH 1/2] NFSD: added FREE_STATEID operation bjschuma
2011-05-20 20:16 ` Bryan Schumaker
2011-05-25 15:05 ` J. Bruce Fields
2011-05-31 14:52 ` Bryan Schumaker [this message]
2011-05-20 20:13 ` [PATCH 2/2] NFSD: Added TEST_STATEID operation bjschuma
2011-06-29 19:49 ` Bryan Schumaker
2011-06-29 19:54 ` J. Bruce Fields
2011-06-29 20:34 ` Bryan Schumaker
2011-06-29 20:40 ` J. Bruce Fields
2011-07-12 10:59 ` J. Bruce Fields
2011-07-12 12:40 ` Bryan Schumaker
2011-07-12 12:42 ` J. Bruce Fields
2011-05-20 20:13 ` [PATCH v2 0/2] NFSD: add FREE_STATEID and TEST_STATEID operations Bryan Schumaker
-- strict thread matches above, loose matches on Subject: below --
2011-05-06 18:57 [PATCH " bjschuma
2011-05-06 18:57 ` [PATCH 1/2] NFSD: added FREE_STATEID operation bjschuma
2011-05-10 0:36 ` J. Bruce Fields
2011-05-11 14:41 ` Bryan Schumaker
2011-05-13 21:36 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE50099.6090901@netapp.com \
--to=bjschuma@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.