[PATCH 2/6] ARM: add Highbank core platform support

From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: add Highbank core platform support
Date: Mon, 22 Aug 2011 08:23:51 -0500	[thread overview]
Message-ID: <4E525867.2040500@gmail.com> (raw)
In-Reply-To: <20110822083524.GA15742@S2100-06.ap.freescale.net>

Shawn,

On 08/22/2011 03:35 AM, Shawn Guo wrote:
> On Tue, Aug 16, 2011 at 03:34:54PM -0500, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> This adds basic support for the Calxeda Highbank platform.
>>
>> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>> ---
> [...]
>> +void highbank_init_irq(void)
>> +{
>> +	struct device_node *node;
>> +	struct of_intc_desc desc;
>> +	int n = 0;
>> +
>> +	memset(&desc, 0, sizeof(desc));
>> +	desc.controller = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
>> +	gic_of_init(&desc);
>> +	node = desc.controller;
>> +	for_each_child_of_node(node, desc.controller) {
>> +		gic_of_ppi_init(&desc);
>> +	}
>> +
> I failed to find the implementation of gic_of_ppi_init() in your patch
> series below.

I sent it to the list, but it didn't seem to make it. I'll resend the
series.

>
>   [RFC PATCH 0/3] Yet another GIC OF binding series
> 
> Also one nit: the braces seem redundant.

Left over from some printks...

Rob