From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH 1/2] xen/Kconfig: define EXPERT a bool rather than a string
Date: Wed, 6 May 2020 10:51:38 +0100 [thread overview]
Message-ID: <4a0e868f-ce85-db62-ae22-1bde2aa11be2@xen.org> (raw)
In-Reply-To: <d069d81b-24bf-1aac-3009-63e90a45af4b@suse.com>
Hi Jan,
On 30/04/2020 15:32, Jan Beulich wrote:
> On 30.04.2020 14:43, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Since commit f80fe2b34f08 "xen: Update Kconfig to Linux v5.4" EXPERT
>> can only have two values (enabled or disabled). So switch from a string
>> to a bool.
>>
>> Take the opportunity to replace all "EXPERT = y" to "EXPERT".
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> with a remark:
>
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -33,7 +33,7 @@ source "arch/Kconfig"
>>
>> config ACPI
>> bool
>> - prompt "ACPI (Advanced Configuration and Power Interface) Support" if EXPERT = "y"
>> + prompt "ACPI (Advanced Configuration and Power Interface) Support" if EXPERT
>> depends on ARM_64
>> ---help---
>>
>> @@ -51,7 +51,7 @@ config GICV3
>>
>> config HAS_ITS
>> bool
>> - prompt "GICv3 ITS MSI controller support" if EXPERT = "y"
>> + prompt "GICv3 ITS MSI controller support" if EXPERT
>> depends on GICV3 && !NEW_VGIC
>
> Could I talk you info switching ones like the above (looks like
> there aren't further ones) to ...
>
>> @@ -81,7 +81,7 @@ config SBSA_VUART_CONSOLE
>> SBSA Generic UART implements a subset of ARM PL011 UART.
>>
>> config ARM_SSBD
>> - bool "Speculative Store Bypass Disable" if EXPERT = "y"
>> + bool "Speculative Store Bypass Disable" if EXPERT
>
> ... this more compact form on this occasion?
I will do the switch on commit if there are no more comment.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2020-05-06 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 12:43 [PATCH 0/2] xen: Allow EXPERT mode to be selected from the menuconfig directly Julien Grall
2020-04-30 12:43 ` [PATCH 1/2] xen/Kconfig: define EXPERT a bool rather than a string Julien Grall
2020-04-30 14:32 ` Jan Beulich
2020-05-06 9:51 ` Julien Grall [this message]
2020-04-30 12:43 ` [PATCH 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly Julien Grall
2020-04-30 14:24 ` [PATCH 0/2] " Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a0e868f-ce85-db62-ae22-1bde2aa11be2@xen.org \
--to=julien@xen.org \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.