Re: [PATCH 3/3] PCI: rockchip: use local variable dev consistently

From: Shawn Lin <shawn.lin@rock-chips.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: shawn.lin@rock-chips.com, Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 3/3] PCI: rockchip: use local variable dev consistently
Date: Fri, 7 Jul 2017 08:40:18 +0800	[thread overview]
Message-ID: <4a311df0-cb8e-fa78-d781-cd27fa2f3035@rock-chips.com> (raw)
In-Reply-To: <20170702213030.GE18324@bhelgaas-glaptop.roam.corp.google.com>

Hi Bjorn,

On 2017/7/3 5:30, Bjorn Helgaas wrote:
> On Thu, Jun 29, 2017 at 09:22:49AM +0800, Shawn Lin wrote:
>> We have "struct device *dev" in rockchip_pcie_probe but
>> still fetch it from pdev and rockchip->dev somewhere.
>> This patch tries to improve and no functional change intended.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> 
> Applied to pci/host-rockchip for v4.13, thanks!
> 
> I don't object to patches 1 & 2, but haven't applied them yet in case Rob
> has any comments.

It's possible for patches 1 & 2 to be the candidate of v4.13 at the last
minute? :)

> 
>> ---
>>
>>   drivers/pci/host/pcie-rockchip.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
>> index c545213..eb0a170 100644
>> --- a/drivers/pci/host/pcie-rockchip.c
>> +++ b/drivers/pci/host/pcie-rockchip.c
>> @@ -1482,15 +1482,14 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
>>   	if (err)
>>   		goto err_free_res;
>>   
>> -	rockchip->msg_region = devm_ioremap(rockchip->dev,
>> -					    rockchip->msg_bus_addr, SZ_1M);
>> +	rockchip->msg_region = devm_ioremap(dev, rockchip->msg_bus_addr, SZ_1M);
>>   	if (!rockchip->msg_region) {
>>   		err = -ENOMEM;
>>   		goto err_free_res;
>>   	}
>>   
>>   	list_splice_init(&res, &bridge->windows);
>> -	bridge->dev.parent = &pdev->dev;
>> +	bridge->dev.parent = dev;
>>   	bridge->sysdata = rockchip;
>>   	bridge->busnr = 0;
>>   	bridge->ops = &rockchip_pcie_ops;
>> -- 
>> 1.9.1
>>
>>
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
> 
> 
> 