From: BALATON Zoltan via <qemu-devel@nongnu.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Huacai Chen <chenhuacai@kernel.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 06/12] audio/via-ac97: Simplify code and set user_creatable to false
Date: Sun, 27 Dec 2020 17:47:01 +0100 (CET) [thread overview]
Message-ID: <4a618736-44bb-ccf3-b5bd-e443ab5502b@eik.bme.hu> (raw)
In-Reply-To: <59478f83-35ab-6610-5233-dd300fc8cb27@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
> Hi Zoltan,
>
> On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
>> Remove some unneded, empty code and set user_creatable to false
>> (besides being not implemented yet, so does nothing anyway) it's also
>> normally part of VIA south bridge chips so no need to confuse users
>> showing them these devices.
>
> After contributing during more than 8 years you should know we try
> to avoid to do multiples changes in the same patch ;)
Yes, in my understanding patches should be split if
- it makes bisecting easier or
- makes reviewing easier
Which of the above appies in this case? I think these are changes that
should neither brake anything (as this device doesn't don't do anyting
yet) and adding user_creatable false is a one line change that's easy to
review even with the other changes. If you insist I can split this into
two but I didn't think that would be any better and the series was long
enough already.
Regards,
BALATON Zoltan
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> hw/audio/via-ac97.c | 51 +++++++++++++++++----------------------------
>> 1 file changed, 19 insertions(+), 32 deletions(-)
>
>
next prev parent reply other threads:[~2020-12-27 16:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 1:10 [PATCH 00/12] Misc vt82c686b clean ups BALATON Zoltan via
2020-12-27 1:10 ` [PATCH 12/12] vt82c686: Do not add floppy BALATON Zoltan via
2020-12-27 1:10 ` [PATCH 07/12] vt82c686: Remove vt82c686b_isa_init() function BALATON Zoltan via
2020-12-27 14:36 ` Philippe Mathieu-Daudé
2020-12-27 16:52 ` BALATON Zoltan via
2020-12-27 1:10 ` [PATCH 02/12] vt82c686: Rename AC97/MC97 parts from VT82C686B to VIA BALATON Zoltan via
2020-12-27 15:04 ` Philippe Mathieu-Daudé
2020-12-27 1:10 ` [PATCH 08/12] vt82c686: Remove vt82c686b_pm_init() function BALATON Zoltan via
2020-12-27 14:39 ` Philippe Mathieu-Daudé
2020-12-27 1:10 ` [PATCH 01/12] vt82c686: Add APM and ACPI dependencies for VT82C686 BALATON Zoltan via
2020-12-28 0:35 ` Huacai Chen
2020-12-28 1:41 ` BALATON Zoltan via
2020-12-28 2:03 ` chen huacai
2020-12-27 1:10 ` [PATCH 06/12] audio/via-ac97: Simplify code and set user_creatable to false BALATON Zoltan via
2020-12-27 14:56 ` Philippe Mathieu-Daudé
2020-12-27 16:47 ` BALATON Zoltan via [this message]
2020-12-27 1:10 ` [PATCH 04/12] vt82c686: Remove vt82c686b_[am]c97_init() functions BALATON Zoltan via
2021-01-01 21:07 ` Philippe Mathieu-Daudé
2020-12-27 1:10 ` [PATCH 03/12] vt82c686: Remove unnecessary _DEVICE suffix from type macros BALATON Zoltan via
2020-12-27 14:29 ` Philippe Mathieu-Daudé
2020-12-27 14:33 ` Philippe Mathieu-Daudé
2020-12-27 16:49 ` BALATON Zoltan via
2020-12-27 1:10 ` [PATCH 11/12] vt82c686: Rename some functions to better show where they belong BALATON Zoltan via
2020-12-27 14:25 ` Philippe Mathieu-Daudé
2020-12-27 1:10 ` [PATCH 10/12] vt82c686: Remove unneeded includes and defines BALATON Zoltan via
2020-12-27 14:51 ` Philippe Mathieu-Daudé
2020-12-27 1:10 ` [PATCH 05/12] vt82c686: Split off via-[am]c97 into separate file in hw/audio BALATON Zoltan via
2020-12-27 15:03 ` Philippe Mathieu-Daudé
2020-12-27 1:10 ` [PATCH 09/12] vt82c686: Convert debug printf to trace points BALATON Zoltan via
2020-12-27 15:08 ` Philippe Mathieu-Daudé
2020-12-27 16:42 ` BALATON Zoltan via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a618736-44bb-ccf3-b5bd-e443ab5502b@eik.bme.hu \
--to=qemu-devel@nongnu.org \
--cc=balaton@eik.bme.hu \
--cc=chenhuacai@kernel.org \
--cc=f4bug@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.