From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Petre Pircalabu" <ppircalabu@bitdefender.com>,
"Juergen Gross" <jgross@suse.com>,
"Kevin Tian" <kevin.tian@intel.com>,
"Tamas K Lengyel" <tamas@tklengyel.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
RazvanCojocaru <rcojocaru@bitdefender.com>,
"Wei Liu" <wl@xen.org>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Alexandru Isaila" <aisaila@bitdefender.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] SVM: correct CPUID event processing
Date: Fri, 20 Sep 2019 10:55:09 +0200 [thread overview]
Message-ID: <4a83a10b-2457-6e27-9b7e-a56d62c7eba9@suse.com> (raw)
In-Reply-To: <f7660d87-a36d-80b0-f44d-21a31d80aa84@citrix.com>
On 20.09.2019 10:50, Andrew Cooper wrote:
> On 19/09/2019 11:37, Jan Beulich wrote:
>> hvm_monitor_cpuid() expects the input registers, not two of the outputs.
>
> Perhaps worth nothing that this has been broken since its introduction
> in c/s d05f1eb3741b85 ?
Ah, yes, I should have done this. I've added half a sentence.
>> However, once having made the necessary adjustment, the SVM and VMX
>> functions are so similar that they should be folded (thus avoiding
>> further similar asymmetries to get introduced). Use the best of both
>> worlds by e.g. using "curr" consistently. This then being the only
>> caller of hvm_check_cpuid_faulting(), fold in that function as well.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thanks.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-20 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 10:37 [Xen-devel] [PATCH] SVM: correct CPUID event processing Jan Beulich
2019-09-19 20:07 ` Boris Ostrovsky
2019-09-19 20:36 ` Razvan COJOCARU
2019-09-20 8:39 ` Alexandru Stefan ISAILA
2019-09-20 8:44 ` Jan Beulich
2019-09-20 8:50 ` Andrew Cooper
2019-09-20 8:55 ` Jan Beulich [this message]
2019-09-25 9:18 ` Jürgen Groß
2019-09-25 9:19 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a83a10b-2457-6e27-9b7e-a56d62c7eba9@suse.com \
--to=jbeulich@suse.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=ppircalabu@bitdefender.com \
--cc=rcojocaru@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.