From: Justin Iurman <justin.iurman@uliege.be>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
David Ahern <dsahern@kernel.org>,
linux-kselftest@vger.kernel.org,
Po-Hsu Lin <po-hsu.lin@canonical.com>,
Guillaume Nault <gnault@redhat.com>,
Petr Machata <petrm@nvidia.com>,
James Prestwood <prestwoj@gmail.com>,
Jaehee Park <jhpark1013@gmail.com>,
Ido Schimmel <idosch@nvidia.com>,
Francesco Ruggeri <fruggeri@arista.com>,
Xin Long <lucien.xin@gmail.com>,
justin.iurman@uliege.be
Subject: Re: [PATCHv2 net-next 10/14] selftests/net: convert ioam6.sh to run it in unique namespace
Date: Thu, 30 Nov 2023 14:28:51 +0100 [thread overview]
Message-ID: <4ab6e843-fd60-4abf-a23f-c8032e617f5c@uliege.be> (raw)
In-Reply-To: <20231130040105.1265779-11-liuhangbin@gmail.com>
On 11/30/23 05:01, Hangbin Liu wrote:
> Here is the test result after conversion.
>
> ]# ./ioam6.sh
>
> --------------------------------------------------------------------------
> OUTPUT tests
> --------------------------------------------------------------------------
> TEST: Unknown IOAM namespace (inline mode) [ OK ]
> TEST: Unknown IOAM namespace (encap mode) [ OK ]
> TEST: Missing trace room (inline mode) [ OK ]
> TEST: Missing trace room (encap mode) [ OK ]
> TEST: Trace type with bit 0 only (inline mode) [ OK ]
> ...
> TEST: Full supported trace (encap mode) [ OK ]
>
> --------------------------------------------------------------------------
> GLOBAL tests
> --------------------------------------------------------------------------
> TEST: Forward - Full supported trace (inline mode) [ OK ]
> TEST: Forward - Full supported trace (encap mode) [ OK ]
>
> - Tests passed: 88
> - Tests failed: 0
>
> Acked-by: David Ahern <dsahern@kernel.org>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Justin Iurman <justin.iurman@uliege.be>
LGTM. Just one question though. Is there any reason not to use
cleanup_ns everywhere? There is the following diff (actually, 3 times):
> - ip netns del ioam-tmp-node || true
> + ip netns del $ioam_tmp_node || true
While, at the same time, there is the following diff (as expected):
> - ip netns del ioam-node-alpha || true
> - ip netns del ioam-node-beta || true
> - ip netns del ioam-node-gamma || true
> + cleanup_ns $ioam_node_alpha $ioam_node_beta $ioam_node_gamma
IMO, it looks like cleanup_ns can safely replace all "ip netns del"
instances in ioam6.sh.
next prev parent reply other threads:[~2023-11-30 13:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 4:00 [PATCHv2 net-next 00/14] Conver net selftests to run in unique namespace (Part 1) Hangbin Liu
2023-11-30 4:00 ` [PATCHv2 net-next 01/14] selftests/net: add lib.sh Hangbin Liu
2023-11-30 10:40 ` Petr Machata
2023-12-01 5:56 ` Po-Hsu Lin
2023-12-01 6:20 ` Hangbin Liu
2023-11-30 4:00 ` [PATCHv2 net-next 02/14] selftests/net: convert arp_ndisc_evict_nocarrier.sh to run it in unique namespace Hangbin Liu
2023-11-30 4:00 ` [PATCHv2 net-next 03/14] selftests/net: specify the interface when do arping Hangbin Liu
2023-11-30 4:00 ` [PATCHv2 net-next 04/14] selftests/net: convert arp_ndisc_untracked_subnets.sh to run it in unique namespace Hangbin Liu
2023-11-30 4:00 ` [PATCHv2 net-next 05/14] selftests/net: convert cmsg tests to make them run " Hangbin Liu
2023-11-30 4:00 ` [PATCHv2 net-next 06/14] selftests/net: convert drop_monitor_tests.sh to run it " Hangbin Liu
2023-11-30 4:00 ` [PATCHv2 net-next 07/14] selftests/net: convert traceroute.sh " Hangbin Liu
2023-11-30 4:00 ` [PATCHv2 net-next 08/14] selftests/net: convert icmp_redirect.sh " Hangbin Liu
2023-11-30 4:01 ` [PATCHv2 net-next 09/14] sleftests/net: convert icmp.sh " Hangbin Liu
2023-11-30 4:01 ` [PATCHv2 net-next 10/14] selftests/net: convert ioam6.sh " Hangbin Liu
2023-11-30 13:28 ` Justin Iurman [this message]
2023-12-01 6:43 ` Hangbin Liu
2023-12-01 10:49 ` Justin Iurman
2023-11-30 4:01 ` [PATCHv2 net-next 11/14] selftests/net: convert l2tp.sh " Hangbin Liu
2023-11-30 9:34 ` James Chapman
2023-11-30 4:01 ` [PATCHv2 net-next 12/14] selftests/net: convert ndisc_unsolicited_na_test.sh " Hangbin Liu
2023-11-30 4:01 ` [PATCHv2 net-next 13/14] selftests/net: convert sctp_vrf.sh " Hangbin Liu
2023-11-30 20:57 ` Xin Long
2023-11-30 4:01 ` [PATCHv2 net-next 14/14] selftests/net: convert unicast_extensions.sh " Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ab6e843-fd60-4abf-a23f-c8032e617f5c@uliege.be \
--to=justin.iurman@uliege.be \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fruggeri@arista.com \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=jhpark1013@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=po-hsu.lin@canonical.com \
--cc=prestwoj@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.