From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, david@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns
Date: Mon, 3 Jul 2017 14:23:21 -0700 [thread overview]
Message-ID: <4acd2bb1-c140-01b9-a76a-fb08c1d899cb@twiddle.net> (raw)
In-Reply-To: <20170702131804.7it62euy4mah63x6@aurel32.net>
On 07/02/2017 06:18 AM, Aurelien Jarno wrote:
>> + if (!s390_has_feat(s->insn->fac == S390_FEAT_EXTENDED_TRANSLATION_3
>> + ? S390_FEAT_ETF3_ENH : S390_FEAT_ETF2_ENH)) {
>> + m3 = 0;
>> + }
>
> This doesn't look correct to me. The well-formedness checking is part of
> ETF3_ENH facility, for both convert unicode instructions that are part
> of the Z architecture (CU12 and CU21) and for the ones added by the ETF3
> facility (CU14 and CU24).
Quite right.
r~
next prev parent reply other threads:[~2017-07-03 21:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 20:25 [Qemu-devel] [PATCH v2 0/8] target/s390x tcg patches Richard Henderson
2017-07-01 20:25 ` [Qemu-devel] [PATCH v2 1/8] target/s390x: Implement CSST Richard Henderson
2017-07-01 20:25 ` [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns Richard Henderson
2017-07-02 13:18 ` Aurelien Jarno
2017-07-03 21:23 ` Richard Henderson [this message]
2017-07-01 20:25 ` [Qemu-devel] [PATCH v2 3/8] target/s390x: Tidy SRST Richard Henderson
2017-07-07 23:03 ` Aurelien Jarno
2017-07-01 20:25 ` [Qemu-devel] [PATCH v2 4/8] target/s390x: Implement SRSTU Richard Henderson
2017-07-07 23:05 ` Aurelien Jarno
2017-07-01 20:25 ` [Qemu-devel] [PATCH v2 5/8] target/s390x: Implement TRTR Richard Henderson
2017-07-01 20:25 ` [Qemu-devel] [PATCH v2 6/8] target/s390x: Mark ETF3 and ETF3_ENH facilities as available Richard Henderson
2017-07-01 20:25 ` [Qemu-devel] [PATCH v2 7/8] target/s390x: Allow to enable "idtes" feature for TCG Richard Henderson
2017-07-01 20:26 ` [Qemu-devel] [PATCH v2 8/8] target/s390x: Fix risbg handling Richard Henderson
2017-07-02 13:18 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4acd2bb1-c140-01b9-a76a-fb08c1d899cb@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.