From: Scott Branden <scott.branden@broadcom.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Brown <david.brown@linaro.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Shuah Khan <shuah@kernel.org>,
bjorn.andersson@linaro.org,
Shuah Khan <skhan@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, Mimi Zohar <zohar@linux.ibm.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Olof Johansson <olof@lixom.net>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Colin Ian King <colin.king@canonical.com>,
Kees Cook <keescook@chromium.org>, Takashi Iwai <tiwai@suse.de>,
linux-kselftest@vger.kernel.org, Andy Gross <agross@kernel.org>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v6 1/8] fs: introduce kernel_pread_file* support
Date: Fri, 5 Jun 2020 21:56:57 -0700 [thread overview]
Message-ID: <4ca91507-90a5-1a99-ab19-c6782423e870@broadcom.com> (raw)
In-Reply-To: <20200606032011.GM19604@bombadil.infradead.org>
Hi Matthew,
On 2020-06-05 8:20 p.m., Matthew Wilcox wrote:
> On Fri, Jun 05, 2020 at 03:59:52PM -0700, Scott Branden wrote:
>> -int kernel_read_file(struct file *file, void **buf, loff_t *size,
>> - loff_t max_size, enum kernel_read_file_id id)
>> -{
>> - loff_t i_size, pos;
>> +int kernel_pread_file(struct file *file, void **buf, loff_t *size,
>> + loff_t pos, loff_t max_size,
>> + enum kernel_pread_opt opt,
>> + enum kernel_read_file_id id)
> What is this 'kernel_pread_opt' foolishness? Why not just pass in
> ~0UL as max_size if you want the entire file?
That is not how existing kernel_read_file api works - max_size is specified.
I guess not everyone has unlimited memory to read a file on any size.
>
>> -int kernel_read_file_from_path_initns(const char *path, void **buf,
>> - loff_t *size, loff_t max_size,
>> - enum kernel_read_file_id id)
>> +extern int kernel_pread_file_from_path_initns(const char *path, void **buf,
> extern? really? i'm shocked gcc doesn't vomit on that.
A typo. thanks. You'll have to ask the compiler gods about your shock.
next prev parent reply other threads:[~2020-06-06 4:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 22:59 [PATCH v6 0/8] firmware: add partial read support in request_firmware_into_buf Scott Branden
2020-06-05 22:59 ` [PATCH v6 1/8] fs: introduce kernel_pread_file* support Scott Branden
2020-06-06 3:20 ` Matthew Wilcox
2020-06-06 4:56 ` Scott Branden [this message]
2020-06-05 22:59 ` [PATCH v6 2/8] firmware: add offset to request_firmware_into_buf Scott Branden
2020-06-06 1:34 ` kernel test robot
2020-06-06 1:34 ` kernel test robot
2020-06-05 22:59 ` [PATCH v6 3/8] test_firmware: add partial read support for request_firmware_into_buf Scott Branden
2020-06-05 22:59 ` [PATCH v6 4/8] firmware: test partial file reads of request_firmware_into_buf Scott Branden
2020-06-05 22:59 ` [PATCH v6 5/8] bcm-vk: add bcm_vk UAPI Scott Branden
2020-06-05 22:59 ` [PATCH v6 6/8] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-06-05 22:59 ` [PATCH v6 7/8] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
2020-06-05 22:59 ` [PATCH v6 8/8] ima: add FIRMWARE_PARTIAL_READ support Scott Branden
2020-06-05 23:19 ` Mimi Zohar
2020-06-05 23:31 ` Scott Branden
2020-06-05 23:48 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca91507-90a5-1a99-ab19-c6782423e870@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=agross@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=olof@lixom.net \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.