Re: [PATCH] dax: constify the struct device_type usage

From: Dave Jiang <dave.jiang@intel.com>
To: "Ricardo B. Marliere" <ricardo@marliere.net>,
	Dan Williams <dan.j.williams@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>
Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] dax: constify the struct device_type usage
Date: Fri, 23 Feb 2024 17:06:01 -0700	[thread overview]
Message-ID: <4cafe9e0-1a08-4574-aa0d-5070b67f8cf3@intel.com> (raw)
In-Reply-To: <20240219-device_cleanup-dax-v1-1-6b319ee89dc2@marliere.net>


On 2/19/24 5:47 AM, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the
> dax_mapping_type variable to be a constant structure as well, placing it
> into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/dax/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 1ff1ab5fa105..e265ba019785 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -763,7 +763,7 @@ static const struct attribute_group *dax_mapping_attribute_groups[] = {
>  	NULL,
>  };
>  
> -static struct device_type dax_mapping_type = {
> +static const struct device_type dax_mapping_type = {
>  	.release = dax_mapping_release,
>  	.groups = dax_mapping_attribute_groups,
>  };
> 
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20240219-device_cleanup-dax-d82fd0c67ffd
> 
> Best regards,