From: Jan Beulich <jbeulich@suse.com>
To: Simone Ballarin <simone.ballarin@bugseng.com>
Cc: consulting@bugseng.com,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wl@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH 2/2] xen: address violations of MISRA C Rule 17.1
Date: Wed, 20 Mar 2024 10:11:57 +0100 [thread overview]
Message-ID: <4ce30a38-5b5c-4d4c-a0c4-8c1a63759203@suse.com> (raw)
In-Reply-To: <f7c2f12ab1b62301cfea3a28707178950f480932.1710923235.git.simone.ballarin@bugseng.com>
On 20.03.2024 09:51, Simone Ballarin wrote:
> MISRA C Rule 20.7 states: "The features of `<stdarg.h>' shall not be used"
>
> The Xen community wants to avoid using variadic functions except for
> specific circumstances where it feels appropriate by strict code review.
>
> Functions hypercall_create_continuation and hypercall_xlat_continuation
> are special hypercalls made to break long running hypercalls into multiple
> calls.
Here and below: These aren't "special hypercalls". They're internal helper
functions.
> They take a variable number of arguments depending on the original
> hypercall they are trying to continue.
Am I misremembering or did Andrew outline a plan to eliminate the variadic-
ness from these? From certifiability perspective avoiding the need for a
deviation would likely be preferable?
Jan
next prev parent reply other threads:[~2024-03-20 9:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 8:50 [XEN PATCH 0/2] xen: address violations of MISRA C Rule 17.1 Simone Ballarin
2024-03-20 8:50 ` [XEN PATCH 1/2] automation/eclair: add deviation for MISRA C:2012 " Simone Ballarin
2024-03-20 9:08 ` Jan Beulich
2024-03-21 1:50 ` Stefano Stabellini
2024-03-21 8:09 ` Jan Beulich
2024-03-21 18:00 ` Stefano Stabellini
2024-03-22 8:08 ` Simone Ballarin
2024-03-20 8:51 ` [XEN PATCH 2/2] xen: address violations of MISRA C " Simone Ballarin
2024-03-20 9:11 ` Jan Beulich [this message]
2024-03-21 1:47 ` Stefano Stabellini
2024-03-22 8:30 ` Simone Ballarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ce30a38-5b5c-4d4c-a0c4-8c1a63759203@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=consulting@bugseng.com \
--cc=george.dunlap@citrix.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=simone.ballarin@bugseng.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.