Re: [PATCH v17 0/3] Add TDX Guest Attestation support

From: Sathyanarayanan Kuppuswamy  <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, Shuah Khan <shuah@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: "H . Peter Anvin" <hpa@zytor.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Tony Luck <tony.luck@intel.com>, Kai Huang <kai.huang@intel.com>,
	Wander Lairson Costa <wander@redhat.com>,
	Isaku Yamahata <isaku.yamahata@gmail.com>,
	marcelo.cerri@canonical.com, tim.gardner@canonical.com,
	khalid.elmously@canonical.com, philip.cox@canonical.com,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v17 0/3] Add TDX Guest Attestation support
Date: Wed, 9 Nov 2022 19:41:35 -0800	[thread overview]
Message-ID: <4d7da783-f01e-504c-f40a-a5aed9a185bb@linux.intel.com> (raw)
In-Reply-To: <20221104032355.227814-1-sathyanarayanan.kuppuswamy@linux.intel.com>

Hi Boris/Dave,

On 11/3/22 8:23 PM, Kuppuswamy Sathyanarayanan wrote:
> Hi All,
> 
> Intel's Trust Domain Extensions (TDX) protect guest VMs from malicious
> hosts and some physical attacks. VM guest with TDX support is called
> as a TDX Guest.
> 
> In TDX guest, attestation process is used to verify the TDX guest
> trustworthiness to other entities before provisioning secrets to the
> guest. For example, a key server may request for attestation before
> releasing the encryption keys to mount the encrypted rootfs or
> secondary drive.
> 
> This patch set adds attestation support for the TDX guest. Details
> about the TDX attestation process and the steps involved are explained
> in Documentation/x86/tdx.rst (added by patch 2/3).
> 
> Following are the details of the patch set:
> 
> Patch 1/3 -> Preparatory patch for adding attestation support.
> Patch 2/3 -> Adds user interface driver to support attestation.
> Patch 3/3 -> Adds selftest support for TDREPORT feature.
> 
> Commit log history is maintained in the individual patches.
> 
> Current overall status of this series is, it has no pending issues
> and can be considered for the upcoming merge cycle.
> 

Any comments on this series? If you are fine with the current version,
I'm wondering if this can be considered for the upcoming merge window.
Please let me know what you think.

> Kuppuswamy Sathyanarayanan (3):
>   x86/tdx: Add a wrapper to get TDREPORT from the TDX Module
>   virt: Add TDX guest driver
>   selftests: tdx: Test TDX attestation GetReport support
> 
>  Documentation/virt/coco/tdx-guest.rst        |  42 +++++
>  Documentation/virt/index.rst                 |   1 +
>  Documentation/x86/tdx.rst                    |  43 +++++
>  arch/x86/coco/tdx/tdx.c                      |  38 +++++
>  arch/x86/include/asm/tdx.h                   |   2 +
>  drivers/virt/Kconfig                         |   2 +
>  drivers/virt/Makefile                        |   1 +
>  drivers/virt/coco/tdx-guest/Kconfig          |  10 ++
>  drivers/virt/coco/tdx-guest/Makefile         |   2 +
>  drivers/virt/coco/tdx-guest/tdx-guest.c      | 102 ++++++++++++
>  include/uapi/linux/tdx-guest.h               |  41 +++++
>  tools/testing/selftests/Makefile             |   1 +
>  tools/testing/selftests/tdx/Makefile         |   7 +
>  tools/testing/selftests/tdx/config           |   1 +
>  tools/testing/selftests/tdx/tdx_guest_test.c | 163 +++++++++++++++++++
>  15 files changed, 456 insertions(+)
>  create mode 100644 Documentation/virt/coco/tdx-guest.rst
>  create mode 100644 drivers/virt/coco/tdx-guest/Kconfig
>  create mode 100644 drivers/virt/coco/tdx-guest/Makefile
>  create mode 100644 drivers/virt/coco/tdx-guest/tdx-guest.c
>  create mode 100644 include/uapi/linux/tdx-guest.h
>  create mode 100644 tools/testing/selftests/tdx/Makefile
>  create mode 100644 tools/testing/selftests/tdx/config
>  create mode 100644 tools/testing/selftests/tdx/tdx_guest_test.c
> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer