From: Jens Axboe <axboe@kernel.dk>
To: Bob Liu <bob.liu@oracle.com>, linux-block@vger.kernel.org
Cc: martin.petersen@oracle.com, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, io-uring@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] userspace PI passthrough via io_uring
Date: Wed, 26 Feb 2020 07:25:11 -0700 [thread overview]
Message-ID: <4defe33b-689e-04c1-a1d5-c2e7a572027e@kernel.dk> (raw)
In-Reply-To: <20200226083719.4389-1-bob.liu@oracle.com>
On 2/26/20 1:37 AM, Bob Liu wrote:
> This RFC provides a rough implementation of a mechanism to allow
> userspace to attach protection information (e.g. T10 DIF) data to a
> disk write and to receive the information alongside a disk read.
> The interface is an extension to the io_uring interface:
> two new commands (IORING_OP_READV{WRITEV}_PI) are provided.
> The last struct iovec in the arg list is interpreted to point to a buffer
> containing the the PI data.
>
> Patch #1 add two new commands to io_uring.
> Patch #2 introduces two helper funcs in bio-integrity.
> Patch #3 implement the PI passthrough in direct-io of block-dev.
> (Similar extensions may add to fs/direct-io.c and fs/maps/directio.c)
> Patch #4 add io_uring use space test case to liburing.
No strong feelings on the support in general, the io_uring bits are
trivial enough (once fixed up, per comments in that patch) that I
have no objections on that front.
I'd really like Martin to render an opinion on the API (PI info in
last vec), since he's the integrity guy.
--
Jens Axboe
prev parent reply other threads:[~2020-02-26 14:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 8:37 [RFC PATCH 0/4] userspace PI passthrough via io_uring Bob Liu
2020-02-26 8:37 ` [PATCH 1/4] io_uring: add IORING_OP_READ{WRITE}V_PI cmd Bob Liu
2020-02-26 14:24 ` Jens Axboe
2020-02-26 15:57 ` Christoph Hellwig
2020-02-26 15:58 ` Jens Axboe
2020-02-26 16:03 ` Darrick J. Wong
2020-02-26 16:53 ` Christoph Hellwig
2020-02-27 9:19 ` Bob Liu
2020-02-27 9:05 ` Bob Liu
2020-02-26 8:37 ` [PATCH 2/4] bio-integrity: introduce two funcs handle protect information Bob Liu
2020-02-26 16:03 ` Darrick J. Wong
2020-02-27 9:23 ` Bob Liu
2020-02-26 8:37 ` [PATCH 3/4] block_dev: support protect information passthrough Bob Liu
2020-02-26 16:04 ` Darrick J. Wong
2020-02-26 8:37 ` [PATCH 4/4] liburing/test: add testcase for " Bob Liu
2020-02-26 14:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4defe33b-689e-04c1-a1d5-c2e7a572027e@kernel.dk \
--to=axboe@kernel.dk \
--cc=bob.liu@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.