From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Edwin Török" <edvin.torok@citrix.com>, xen-devel@lists.xenproject.org
Cc: Christian Lindig <christian.lindig@citrix.com>,
David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>,
Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/ocaml/libs/xc: add OCaml stubs to query CPU policy
Date: Fri, 18 Jun 2021 14:17:10 +0100 [thread overview]
Message-ID: <4eb5d3fb-db71-5981-e6f5-0503ff896fd9@citrix.com> (raw)
In-Reply-To: <5fdb7b4cdee69af8e2b9d77b56b1027a8799cf04.1624012999.git.edvin.torok@citrix.com>
On 18/06/2021 11:45, Edwin Török wrote:
> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
> index d05d7bb30e..4a230de8b7 100644
> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
> @@ -34,6 +34,9 @@
> #include <xenctrl.h>
> #include <xen-tools/libs.h>
>
> +#include <xen/lib/x86/cpuid.h>
> +#include <xen/lib/x86/msr.h>
https://gitlab.com/xen-project/patchew/xen/-/jobs/1358403495
CI says no. This needs to be behind a suitable ifdef, for non-x86 builds.
(I've not looked at the rest of the patch yet. I'll get around to it at
some point.)
~Andrew
next prev parent reply other threads:[~2021-06-18 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 10:45 [PATCH] tools/ocaml/libs/xc: add OCaml stubs to query CPU policy Edwin Török
2021-06-18 13:09 ` Christian Lindig
2021-06-18 13:42 ` Edwin Torok
2021-06-18 13:17 ` Andrew Cooper [this message]
2021-06-18 13:46 ` Edwin Torok
2021-06-18 17:07 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eb5d3fb-db71-5981-e6f5-0503ff896fd9@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=christian.lindig@citrix.com \
--cc=dave@recoil.org \
--cc=edvin.torok@citrix.com \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.