Re: [PATCH v2 08/11] media: i2c: max9286: Define macros for all bits of register 0x15

From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jacopo Mondi <jacopo@jmondi.org>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Thomas Nizan" <tnizan@witekio.com>
Subject: Re: [PATCH v2 08/11] media: i2c: max9286: Define macros for all bits of register 0x15
Date: Mon, 10 Jan 2022 13:37:51 +0300	[thread overview]
Message-ID: <4ef0af5a-36cd-fd40-73f0-3e5c746e7882@omp.ru> (raw)
In-Reply-To: <Ydtt+TsZ56qv8G27@pendragon.ideasonboard.com>

Hello!

On 1/10/22 2:21 AM, Laurent Pinchart wrote:

>>> Macros are easier to read than numerical values.
>>>
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>> ---
>>>  drivers/media/i2c/max9286.c | 27 ++++++++++++++++++---------
>>>  1 file changed, 18 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
>>> index 24c2bf4fda53..4b69bd036ca6 100644
>>> --- a/drivers/media/i2c/max9286.c
>>> +++ b/drivers/media/i2c/max9286.c
[...]
>>> @@ -810,13 +815,17 @@ static int max9286_s_stream(struct v4l2_subdev *sd, int enable)
>>>  		}
>>>
>>>  		/*
>>> -		 * Enable CSI output, VC set according to link number.
>>> -		 * Bit 7 must be set (chip manual says it's 0 and reserved).
>>> +		 * Configure the CSI-2 output to line interleaved mode (W x (N
>>> +		 * x H), as opposed to the (N x W) x H mode that outputs the
>>> +		 * images stitched side-by-side) and enable it.
>>>  		 */
>>> -		max9286_write(priv, 0x15, 0x80 | MAX9286_VCTYPE |
>>> -			      MAX9286_CSIOUTEN | MAX9286_0X15_RESV);
>>> +		max9286_write(priv, 0x15, MAX9286_CSI_IMAGE_TYP | MAX9286_VCTYPE |
>>> +			      MAX9286_CSIOUTEN | MAX9286_EN_CCBSYB_CLK_STR |
>>> +			      MAX9286_EN_GPI_CCBSYB);
>>>  	} else {
>>> -		max9286_write(priv, 0x15, MAX9286_VCTYPE | MAX9286_0X15_RESV);
>>> +		max9286_write(priv, 0x15, MAX9286_VCTYPE |
>>> +			      MAX9286_EN_CCBSYB_CLK_STR |
>>> +			      MAX9286_EN_GPI_CCBSYB);
>>
>> Probably fits better on two lines only.
> 
> That would be over the 80 columns limit, which is a soft limit now, but
> still often requested by reviewers (including myself in quite a few
> cases :-)).

    The new limit is 100 columns, not 80. :-)

[...]

MBR, Sergey