Re: [PATCH rdma-next] RDMA/mlx5: Annotate lock dependency in unbinding slave port

From: Doug Ledford <dledford@redhat.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@mellanox.com>
Cc: Leon Romanovsky <leonro@mellanox.com>,
	RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-next] RDMA/mlx5: Annotate lock dependency in unbinding slave port
Date: Mon, 12 Aug 2019 10:31:19 -0400	[thread overview]
Message-ID: <5008d1458ccbbf368ce8c2235c200798fee480cd.camel@redhat.com> (raw)
In-Reply-To: <20190808083907.29316-1-leon@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

On Thu, 2019-08-08 at 11:39 +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> NULL-ing notifier_call is performed under protection
> of mlx5_ib_multiport_mutex lock. Such protection is
> not easily spotted and better to be guarded by lockdep
> annotation.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> Based on -rc commit: 23eaf3b5c1a7 ("RDMA/mlx5: Release locks during
> notifier unregister")
> ---
>  drivers/infiniband/hw/mlx5/main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/mlx5/main.c
> b/drivers/infiniband/hw/mlx5/main.c
> index 7933534be931..63969484421c 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -5835,6 +5835,8 @@ static void mlx5_ib_unbind_slave_port(struct
> mlx5_ib_dev *ibdev,
>  	int err;
>  	int i;
> 
> +	lockdep_assert_held(&mlx5_ib_multiport_mutex);
> +
>  	mlx5_ib_cleanup_cong_debugfs(ibdev, port_num);
> 
>  	spin_lock(&port->mp.mpi_lock);
> --
> 2.20.1
> 

Hi Leon,

This patch needed to catch both the unbind and the bind/init routine as
they both require the multiport mutex be held.  Can you respin please?

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]