From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH] PCI: Mark expected switch fall-throughs
Date: Wed, 20 Mar 2019 14:41:35 -0500 [thread overview]
Message-ID: <500ce9e7-9a0f-b632-1731-f15a5ba872fd@embeddedor.com> (raw)
In-Reply-To: <b67ab7b5-bb75-4443-1cfc-bb905ac09a15@citrix.com>
On 3/20/19 2:27 PM, Andrew Cooper wrote:
> On 20/03/2019 18:27, Gustavo A. R. Silva wrote:
>> diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
>> index 6fa1627ce08d..445b51db75b0 100644
>> --- a/drivers/pci/proc.c
>> +++ b/drivers/pci/proc.c
>> @@ -222,6 +222,7 @@ static long proc_bus_pci_ioctl(struct file *file, unsigned int cmd,
>> }
>> /* If arch decided it can't, fall through... */
>> #endif /* HAVE_PCI_MMAP */
>> + /* fall through */
>
> Surely it would be better to transpose the #endif and its previous line,
> than to add a second fallthrough ?
>
I agree. The thing is that, currently, GCC is expecting to find the
fall-through "annotations" at the very bottom of the case statement,
as I mentioned it in the changelog text.
That's the reason why I decided to left in place the original comment.
Thanks
--
Gustavo
next prev parent reply other threads:[~2019-03-20 19:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:27 [PATCH] PCI: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-20 19:24 ` Bjorn Helgaas
2019-03-20 19:33 ` Gustavo A. R. Silva
2019-03-20 19:33 ` Gustavo A. R. Silva
2019-03-20 19:24 ` Bjorn Helgaas
2019-03-20 19:27 ` Andrew Cooper
2019-03-20 19:27 ` [Xen-devel] " Andrew Cooper
2019-03-20 19:41 ` Gustavo A. R. Silva
2019-03-20 19:41 ` Gustavo A. R. Silva [this message]
2019-03-20 20:13 ` Bjorn Helgaas
2019-03-20 20:23 ` Gustavo A. R. Silva
2019-03-20 20:23 ` Gustavo A. R. Silva
2019-03-20 20:13 ` Bjorn Helgaas
2019-03-25 13:25 ` Jan Beulich
2019-03-25 13:25 ` [Xen-devel] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500ce9e7-9a0f-b632-1731-f15a5ba872fd@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=andrew.cooper3@citrix.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.