From: Josh Durgin <josh.durgin@inktank.com>
To: Alex Elder <elder@inktank.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 0/6] ceph: simple cleanups (mostly rbd)
Date: Thu, 26 Jul 2012 12:31:06 -0700 [thread overview]
Message-ID: <50119AFA.8080409@inktank.com> (raw)
In-Reply-To: <50118F33.7080502@inktank.com>
On 07/26/2012 11:40 AM, Alex Elder wrote:
> This series includes a set of fairly minor code cleanups in rbd.
> I won't bother summarizing them here. They are all simple nad
> their descriptions ought to be sufficient.
>
> -Alex
>
> [PATCH 1/6] rbd: drop extra header_rwsem init
> [PATCH 2/6] rbd: simplify __rbd_remove_all_snaps()
> [PATCH 3/6] rbd: clean up a few dout() calls
> [PATCH 4/6] ceph: define snap counts as u32 everywhere
> [PATCH 5/6] rbd: encapsulate header validity test
> [PATCH 6/6] rbd: rename rbd_device->id
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
It looks like there are still several dout() calls using
%lld when they should be %llu after these cleanups.
prev parent reply other threads:[~2012-07-26 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 18:40 [PATCH 0/6] ceph: simple cleanups (mostly rbd) Alex Elder
2012-07-26 18:44 ` [PATCH 1/6] rbd: drop extra header_rwsem init Alex Elder
2012-07-26 18:44 ` [PATCH 2/6] rbd: simplify __rbd_remove_all_snaps() Alex Elder
2012-07-26 18:44 ` [PATCH 3/6] rbd: clean up a few dout() calls Alex Elder
2012-07-26 18:45 ` [PATCH 4/6] ceph: define snap counts as u32 everywhere Alex Elder
2012-07-26 18:45 ` [PATCH 5/6] rbd: encapsulate header validity test Alex Elder
2012-07-26 18:45 ` [PATCH 6/6] rbd: rename rbd_device->id Alex Elder
2012-07-26 19:31 ` Josh Durgin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50119AFA.8080409@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.