From: "Huang, Kai" <kai.huang@intel.com>
To: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"haitao.huang@linux.intel.com" <haitao.huang@linux.intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>
Cc: "mingo@kernel.org" <mingo@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] x86/sgx: Return VM_FAULT_SIGBUS for EPC exhaustion
Date: Thu, 26 Oct 2023 21:16:28 +0000 [thread overview]
Message-ID: <504d71debc56c89860942283ae638e5950deb79c.camel@intel.com> (raw)
In-Reply-To: <op.2dfkbh2iwjvjmi@hhuan26-mobl.amr.corp.intel.com>
On Thu, 2023-10-26 at 11:34 -0500, Haitao Huang wrote:
> On Thu, 26 Oct 2023 11:01:57 -0500, Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>
> >
> >
> > On 10/25/2023 4:58 PM, Huang, Kai wrote:
> > > On Wed, 2023-10-25 at 07:31 -0700, Hansen, Dave wrote:
> > > > On 10/19/23 19:53, Haitao Huang wrote:
> > > > > In the EAUG on page fault path, VM_FAULT_OOM is returned when the
> > > > > Enclave Page Cache (EPC) runs out. This may trigger unneeded OOM kill
> > > > > that will not free any EPCs. Return VM_FAULT_SIGBUS instead.
> >
> > This commit message does not seem accurate to me. From what I can tell
> > VM_FAULT_SIGBUS is indeed returned when EPC runs out. What is addressed
> > with this patch is the error returned when kernel (not EPC) memory runs
> > out.
> >
>
>
> Sorry I got it mixed up between sgx_alloc_epc_page and sgx_encl_page_alloc
> returns.
> You are right. Please drop this patch.
>
It's already in tip/x86/urgent. Please send a patch to revert?
next prev parent reply other threads:[~2023-10-26 21:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 2:53 [PATCH] x86/sgx: Return VM_FAULT_SIGBUS for EPC exhaustion Haitao Huang
2023-10-23 23:30 ` Jarkko Sakkinen
2023-10-25 14:31 ` Dave Hansen
2023-10-25 23:58 ` Huang, Kai
2023-10-26 16:01 ` Reinette Chatre
2023-10-26 16:34 ` Haitao Huang
2023-10-26 21:16 ` Huang, Kai [this message]
2023-10-28 8:24 ` Ingo Molnar
2023-10-26 21:10 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504d71debc56c89860942283ae638e5950deb79c.camel@intel.com \
--to=kai.huang@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=haitao.huang@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.