All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] da8xx-fb: move panel information from driver to platform file
Date: Mon, 08 Oct 2012 12:52:12 +0000	[thread overview]
Message-ID: <5072C9AC.70901@ti.com> (raw)
In-Reply-To: <1349445084-9857-2-git-send-email-prakash.pm@ti.com>

Hi Prakash,

On 10/5/2012 7:21 PM, Manjunathappa, Prakash wrote:
> Moving panel information from driver to platform file, patch also made
> compliant to fb_videomode data.
> 
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>

Why do you have to do this? Just moving panel data from driver to
platform code doesn't seem to buy anything.

If you are passed DT data, then use it else continue the existing
platform data method? Once all the boards using this driver are
converted to DT, then all the panel information can be removed from
driver. That will save code.

This patch looks like needless churn.

Thanks,
Sekhar

  reply	other threads:[~2012-10-08 12:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-05 14:03 [PATCH 1/2] da8xx-fb: move panel information from driver to platform file Manjunathappa, Prakash
2012-10-08 12:52 ` Sekhar Nori [this message]
2012-10-08 16:33 ` Manjunathappa, Prakash
2012-10-09  6:44 ` Sekhar Nori
2012-10-12 12:53 ` Manjunathappa, Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5072C9AC.70901@ti.com \
    --to=nsekhar@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.