From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] irqchip: add basic infrastructure
Date: Sun, 28 Oct 2012 08:30:01 -0500 [thread overview]
Message-ID: <508D3359.6000309@gmail.com> (raw)
In-Reply-To: <20121028142408.7512671c@skate>
On 10/28/2012 08:24 AM, Thomas Petazzoni wrote:
> Rob,
>
> On Sun, 28 Oct 2012 08:18:42 -0500, Rob Herring wrote:
>
>>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>>> index 1bb8bf6..e0ff166 100644
>>> --- a/drivers/irqchip/Kconfig
>>> +++ b/drivers/irqchip/Kconfig
>>> @@ -1 +1,2 @@
>>> -# empty
>>> +config USE_IRQCHIP
>>> + bool
>>
>> This should depend on OF_IRQ.
>
> It is correct that the mechanism only works for irqchip drivers that
> are probed through the Device Tree. However, having a "depends on"
> inside a configuration that gets "select"ed by other configuration
> options (in our case ARCH_BCM2835 and ARCH_MVEBU select USE_IRQCHIP) is
> useless: kconfig doesn't care of the "depends on" dependencies when
> you're "select"ing an option.
>
> So, I can add it for documentation purposes, but it is practically
> useless.
It will give a kconfig error rather than build error on of_irq_init
which would result in patches for empty of_irq_init.
How about default y and depends on OF_IRQ. Then you don't need a select.
I think we want all DT enabled platforms to use this and it's only a
small amount of init space.
Rob
>
> Best regards,
>
> Thomas
>
next prev parent reply other threads:[~2012-10-28 13:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 9:30 [PATCH v2] Introduce minimal irqchip infrastructure Thomas Petazzoni
2012-10-28 9:30 ` [PATCH v2 1/4] irqchip: add basic infrastructure Thomas Petazzoni
2012-10-28 13:18 ` Rob Herring
2012-10-28 13:24 ` Thomas Petazzoni
2012-10-28 13:30 ` Rob Herring [this message]
2012-10-28 13:35 ` Thomas Petazzoni
2012-10-28 9:30 ` [PATCH v2 2/4] arm: bcm2835: convert to the irqchip infrastructure Thomas Petazzoni
2012-10-28 9:30 ` [PATCH v2 3/4] arm: mvebu: move irq controller driver to drivers/irqchip Thomas Petazzoni
2012-10-28 9:41 ` Thomas Petazzoni
2012-10-28 9:42 ` Thomas Petazzoni
2012-10-28 9:30 ` [PATCH v2 4/4] irqchip: add to the directories part of the IRQ subsystem in MAINTAINERS Thomas Petazzoni
2012-10-28 13:11 ` Rob Herring
2012-10-28 13:23 ` [PATCH v2] Introduce minimal irqchip infrastructure Rob Herring
2012-10-28 13:26 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508D3359.6000309@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.