From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/2] ravb: ravb_close() always returns 0
Date: Sat, 29 Jan 2022 13:38:01 +0300 [thread overview]
Message-ID: <50b5fab3-6e06-165d-43eb-dc17c7b3ff99@omp.ru> (raw)
In-Reply-To: <20220128135139.292aab45@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hello!
On 1/29/22 12:51 AM, Jakub Kicinski wrote:
>> ravb_close() always returns 0, hence the check in ravb_wol_restore() is
>> pointless (however, we cannot change the prototype of ravb_close() as it
>> implements the driver's ndo_stop() method).
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>> ---
>> drivers/net/ethernet/renesas/ravb_main.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
>> index b215cde68e10..02fa8cfc2b7b 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> @@ -2863,9 +2863,7 @@ static int ravb_wol_restore(struct net_device *ndev)
>> /* Disable MagicPacket */
>> ravb_modify(ndev, ECMR, ECMR_MPDE, 0);
>>
>> - ret = ravb_close(ndev);
>> - if (ret < 0)
>> - return ret;
>> + ravb_close(ndev);
>>
>> return disable_irq_wake(priv->emac_irq);
>> }
>
> drivers/net/ethernet/renesas/ravb_main.c:2857:13: warning: unused variable ‘ret’ [-Wunused-variable]
> 2857 | int ret;
> | ^~~
Oops, sorry about that!
This patch was created during the merge window and when it finally closed, I rushed
to send this series before the end of week, and forgot to sanity check it (thinking it
has been checked already)... :-/
I'll fix and resend...
MBR, Sergey
next prev parent reply other threads:[~2022-01-29 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 20:38 [PATCH 0/2] Kill some dead code in the Renesas Ethernet drivers Sergey Shtylyov
2022-01-28 20:38 ` [PATCH 1/2] ravb: ravb_close() always returns 0 Sergey Shtylyov
2022-01-28 21:51 ` Jakub Kicinski
2022-01-29 10:38 ` Sergey Shtylyov [this message]
2022-01-28 20:38 ` [PATCH 2/2] sh_eth: sh_eth_close() " Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50b5fab3-6e06-165d-43eb-dc17c7b3ff99@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.