From: duoming@zju.edu.cn
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
isdn@linux-pingi.de
Subject: Re: [PATCH V3] mISDN: fix use-after-free bugs in l1oip timer handlers
Date: Wed, 28 Sep 2022 21:27:40 +0800 (GMT+08:00) [thread overview]
Message-ID: <51008dca.fbc35.1838448187b.Coremail.duoming@zju.edu.cn> (raw)
In-Reply-To: <20220927172618.58f238d6@kernel.org>
Hello,
On Tue, 27 Sep 2022 17:26:18 -0700 Jakub Kicinski wrote:
> On Sat, 24 Sep 2022 10:18:42 +0800 Duoming Zhou wrote:
> > + del_timer_sync(&hc->keep_tl);
> > + del_timer_sync(&hc->timeout_tl);
> > + cancel_work_sync(&hc->workq);
> > + del_timer_sync(&hc->keep_tl);
> > cancel_work_sync(&hc->workq);
>
> Why not add a bit which will indicate that the device is shutting
> down and check it in places which schedule the timer?
> I think that's much easier to reason about and we won't need to do
> this rep cancel procedure.
Thank you for your time and suggestions!
Best regards,
Duoming Zhou
prev parent reply other threads:[~2022-09-28 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 2:18 [PATCH V3] mISDN: fix use-after-free bugs in l1oip timer handlers Duoming Zhou
2022-09-28 0:26 ` Jakub Kicinski
2022-09-28 13:27 ` duoming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51008dca.fbc35.1838448187b.Coremail.duoming@zju.edu.cn \
--to=duoming@zju.edu.cn \
--cc=isdn@linux-pingi.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.