Re: [External] Re: [PATCH] platform/x86: thinkpad_acpi: Correct dual fan probe

From: Mark Pearson <markpearson@lenovo.com>
To: "Lyude Paul" <lyude@redhat.com>, "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: <hdegoede@redhat.com>, <markgross@kernel.org>,
	<platform-driver-x86@vger.kernel.org>
Subject: Re: [External] Re: [PATCH] platform/x86: thinkpad_acpi: Correct dual fan probe
Date: Thu, 5 May 2022 13:56:33 -0400	[thread overview]
Message-ID: <5122d130-1d9c-6f70-8e6a-b267faf03cbe@lenovo.com> (raw)
In-Reply-To: <bb8fa51d02d84c2a912709f3e308e096b6fe7988.camel@redhat.com>

Hi Lyude,

On 5/5/22 13:32, Lyude Paul wrote:
> So - no promises, but which laptops in particular did you need access to? I
> should have at least:
> 
> P50 (I think??? would have to double check this one), P1 2nd gen, X1 Extreme
> 2nd gen, and I think I may have access to a P51/P52.
> 
> As well, I only have a few old thinkpads (there may actually be a bunch in the
> boston office though). However, given how nice the older thinkpads are it's
> not too unlikely I could poke around my friends who still use ancient
> thinkpads and see if any of them have access to these. Problem is though the
> older IBM models seem to be the ones missing comments with the model numbers,
> so I'd probably need to know what those are. However, given how old these
> machines are feel free not to bother with it if identifying the model numbers
> looks to be too much work.
> 

From the list:

	TPACPI_QEC_IBM('1', 'Y', TPACPI_FAN_Q1), - no idea what this is
	TPACPI_QEC_IBM('7', '8', TPACPI_FAN_Q1), - ditto
	TPACPI_QEC_IBM('7', '6', TPACPI_FAN_Q1), - ditto
	TPACPI_QEC_IBM('7', '0', TPACPI_FAN_Q1), - ditto
	TPACPI_QEC_LNV('7', 'M', TPACPI_FAN_2FAN), - ditto
	TPACPI_Q_LNV('N', '1', TPACPI_FAN_2FAN), - ditto
	TPACPI_Q_LNV3('N', '1', 'D', TPACPI_FAN_2CTL),	/* P70 */ - I don't have
& not in lab
	TPACPI_Q_LNV3('N', '1', 'E', TPACPI_FAN_2CTL),	/* P50 */ - I don't have
- in lab
	TPACPI_Q_LNV3('N', '1', 'T', TPACPI_FAN_2CTL),	/* P71 */ - I don't have
& not in lab
	TPACPI_Q_LNV3('N', '1', 'U', TPACPI_FAN_2CTL),	/* P51 */ - I don't have
- in lab
	TPACPI_Q_LNV3('N', '2', 'C', TPACPI_FAN_2CTL),	/* P52 / P72 */ - have
P52 but not P72 (is in lab)
	TPACPI_Q_LNV3('N', '2', 'N', TPACPI_FAN_2CTL),	/* P53 / P73 */ - don't
have - in lab
	TPACPI_Q_LNV3('N', '2', 'E', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (1st
gen) */ - don't have - in lab
	TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (2nd
gen) */ - don't have - in lab
	TPACPI_Q_LNV3('N', '3', '0', TPACPI_FAN_2CTL),	/* P15 (1st gen) / P15v
(1st gen) */ - have P15, but not P15v (in lab)
	TPACPI_Q_LNV3('N', '3', '7', TPACPI_FAN_2CTL),  /* T15g (2nd gen) */ -
don't have - in lab
	TPACPI_Q_LNV3('N', '1', 'O', TPACPI_FAN_NOFAN),	/* X1 Tablet (2nd gen)
*/ - don't have

For the ones in the US lab so I can get one of my US colleagues to chew
thru them on a quiet day (whenever that happens...). We may be able to
'borrow' systems from the Windows teams for the P70, P71 and maybe X1
Tablet - but they do get a bit annoyed with us because we keep returning
them with a superior OS installed.

I figure given I can't reasonably fix the early platforms I should
refactor the code anyway - and then fixing the ones that are still there
becomes a low priority exercise for a rainy day. At least the list will
stop growing.

I thought I had too many systems - but going thru the list now I'm not
so sure :)

Mark