Re: [PATCH 05/16] blackfin idle: delete pm_idle - Lars-Peter Clausen

From: Lars-Peter Clausen <lars@metafoo.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Len Brown <len.brown@intel.com>,
	uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH 05/16] blackfin idle: delete pm_idle
Date: Wed, 20 Feb 2013 21:21:16 +0100	[thread overview]
Message-ID: <5125303C.3080507@metafoo.de> (raw)
In-Reply-To: <1759773.UdmLmFNAfS@vostro.rjw.lan>

On 02/20/2013 08:59 PM, Rafael J. Wysocki wrote:
> On Wednesday, February 20, 2013 08:53:38 PM Lars-Peter Clausen wrote:
>> On 02/20/2013 08:52 PM, Rafael J. Wysocki wrote:
>>> On Monday, February 18, 2013 05:28:19 PM Lars-Peter Clausen wrote:
>>>> On 02/10/2013 06:58 AM, Len Brown wrote:
>>>>> From: Len Brown <len.brown@intel.com>
>>>>>
>>>>> pm_idle is dead code on blackfin.
>>>>>
>>>>> Signed-off-by: Len Brown <len.brown@intel.com>
>>>>> Cc: uclinux-dist-devel@blackfin.uclinux.org
>>>>> ---
>>>>>  arch/blackfin/kernel/process.c | 7 -------
>>>>>  1 file changed, 7 deletions(-)
>>>>>
>>>>> diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
>>>>> index 3e16ad9..8061426 100644
>>>>> --- a/arch/blackfin/kernel/process.c
>>>>> +++ b/arch/blackfin/kernel/process.c
>>>>> @@ -39,12 +39,6 @@ int nr_l1stack_tasks;
>>>>>  void *l1_stack_base;
>>>>>  unsigned long l1_stack_len;
>>>>>  
>>>>> -/*
>>>>> - * Powermanagement idle function, if any..
>>>>> - */
>>>>> -void (*pm_idle)(void) = NULL;
>>>>> -EXPORT_SYMBOL(pm_idle);
>>>>> -
>>>>>  void (*pm_power_off)(void) = NULL;
>>>>>  EXPORT_SYMBOL(pm_power_off);
>>>>>  
>>>>> @@ -81,7 +75,6 @@ void cpu_idle(void)
>>>>>  {
>>>>>  	/* endless idle loop with no priority at all */
>>>>>  	while (1) {
>>>>> -		void (*idle)(void) = pm_idle;
>>>>
>>>> Hi,
>>>>
>>>> This results in the following error:
>>>>
>>>> arch/blackfin/kernel/process.c: In function ‘cpu_idle’:
>>>> arch/blackfin/kernel/process.c:83: error: ‘idle’ undeclared (first use in
>>>> this function)
>>>> arch/blackfin/kernel/process.c:83: error: (Each undeclared identifier is
>>>> reported only once
>>>> arch/blackfin/kernel/process.c:83: error: for each function it appears in.)
>>>> arch/blackfin/kernel/process.c:88: error: implicit declaration of function
>>>> ‘idle’
>>>>
>>>>
>>>> This change on top of your patch, fixes it.
>>>
>>> Lars, I need your sign-off for the patch below.  May I add it?
>>>
>>> Rafael
>>
>> Sure, I didn't realize the patches had already been merged, otherwise I'd have
>> sent a proper patch.
> 
> Please do now, if you can.  Sorry for the trouble.
> 

I can send it tomorrow morning, it's on my machine at work.

- Lars