From: Stephen Warren <swarren@wwwdotorg.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2] bcm2835: Add Broadcom BCM2835 RNG to the device tree
Date: Tue, 26 Mar 2013 20:55:40 -0600 [thread overview]
Message-ID: <51525FAC.2010106@wwwdotorg.org> (raw)
In-Reply-To: <1364135511-26970-1-git-send-email-lkundrak@v3.sk>
On 03/24/2013 08:31 AM, Lubomir Rintel wrote:
> This adds a device tree binding for random number generator present on Broadcom
> BCM2835 SoC, used in Raspberry Pi and Roku 2 devices.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: linux-rpi-kernel@lists.infradead.org
> ---
> Changes for v2:
> - Split out from the driver changeset
> - Added documentation
>
> .../devicetree/bindings/rng/brcm,bcm2835.txt | 13 +++++++++++++
> arch/arm/boot/dts/bcm2835.dtsi | 5 +++++
> 2 files changed, 18 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/rng/brcm,bcm2835.txt
I think it's more typical to include the binding document with the
driver patch, so that one patch both defines and implements the binding.
A separate patch then instantiates the binding (i.e. adds entries to *.dts).
Patches that create new DT bindings should be posted to
devicetree-discuss@lists.ozlabs.org, although this one is so simple that
I doubt it will generate any discussion.
Patches that affect ARM files should be posted to
linux-arm-kernel@lists.infradead.org. I typically post there instead of
the main linux-kernel@ mailing list.
I assume you're going to repost this anyway once you've addressed the
authorship issue, so you'll have an opportunity to correct all this.
The actual content of this patch seems fine.
next prev parent reply other threads:[~2013-03-27 2:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 12:55 [PATCH] hw_random: Add Broadcom BCM2835 RNG Driver Lubomir Rintel
2013-03-23 2:44 ` Stephen Warren
2013-03-24 14:37 ` Lubomir Rintel
2013-03-27 2:52 ` Stephen Warren
2013-03-28 6:15 ` Lubomir Rintel
2013-03-24 14:31 ` [PATCH v2] bcm2835: Add Broadcom BCM2835 RNG to the device tree Lubomir Rintel
2013-03-24 14:39 ` [PATCH v2] hw_random: Add Broadcom BCM2835 RNG driver Lubomir Rintel
2013-03-24 14:41 ` [PATCH v2] arm: Add Broadcom BCM2835 RNG driver to bcm2835_defconfig Lubomir Rintel
2013-04-03 6:28 ` Stephen Warren
2013-03-27 3:00 ` [PATCH v2] hw_random: Add Broadcom BCM2835 RNG driver Stephen Warren
2013-03-27 3:20 ` Stephen Warren
2013-03-28 6:19 ` [PATCH v3] " Lubomir Rintel
2013-04-03 1:53 ` Herbert Xu
2013-03-27 2:55 ` Stephen Warren [this message]
2013-03-28 6:12 ` [PATCH] bcm2835: Add Broadcom BCM2835 RNG to the device tree Lubomir Rintel
2013-03-28 6:12 ` Lubomir Rintel
2013-04-02 2:38 ` Stephen Warren
2013-04-02 2:38 ` Stephen Warren
2013-04-03 6:28 ` Stephen Warren
2013-04-03 6:28 ` Stephen Warren
2013-03-24 14:25 [PATCH v2] arm: Add Broadcom BCM2835 watchdog timer driver to bcm2835_defconfig Lubomir Rintel
2013-03-26 17:48 ` [PATCH v2] bcm2835: Add Broadcom BCM2835 RNG to the device tree Lubomir Rintel
2013-03-26 17:50 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51525FAC.2010106@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.