From: Brian Behlendorf <behlendorf1@llnl.gov>
To: Yehuda Sadeh <yehuda@inktank.com>
Cc: Sage Weil <sage@inktank.com>,
Jeff Mitchell <jeffrey.mitchell@gmail.com>,
Henry C Chang <henry.cy.chang@gmail.com>,
Aleksey Leonov <aleonov@nazarianin.com>,
ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: test osd on zfs
Date: Wed, 17 Apr 2013 11:57:02 -0700 [thread overview]
Message-ID: <516EF07E.4000909@llnl.gov> (raw)
In-Reply-To: <CABBk=J_k0gAEx6a-agno8KHtn4-iZe5pfQLcrgtU2Ki2_kd8nQ@mail.gmail.com>
Here's a patch for the ERANGE error (lightly tested). Sage's patch
looks good but only covers one of two code paths for xattrs. With zfs
they may either be stored as a system attribute which is usually close
to the dnode on disk (zfs set xattr=sa pool/dataset). Or they may be
stored in their own object which is how it's implemented on Solaris (zfs
set xattr=on pool/dataset). The second method is still the default for
compatibility reasons even though it's slower. Sage's patch only
covered the SA case.
> Well, looking at the code again it's not going to work, as setxattr is
> going to fail with ERANGE.
Why? We support an arbitrary number of maximum sized xattrs (65536).
What am I missing here?
Incidentally, does anybody know of an good xattr test suite we could add
to our regression tests?
Thanks,
Brian
diff --git a/module/zfs/zpl_xattr.c b/module/zfs/zpl_xattr.c
index c03764f..9f4d63c 100644
--- a/module/zfs/zpl_xattr.c
+++ b/module/zfs/zpl_xattr.c
@@ -225,6 +225,11 @@ zpl_xattr_get_dir(struct inode *ip, const char
*name, void *value,
goto out;
}
+ if (size < i_size_read(xip)) {
+ error = -ERANGE;
+ goto out;
+ }
+
error = zpl_read_common(xip, value, size, 0, UIO_SYSSPACE, 0, cr);
out:
if (xip)
@@ -263,7 +268,10 @@ zpl_xattr_get_sa(struct inode *ip, const char
*name, void *value, size_t size)
if (!size)
return (nv_size);
- memcpy(value, nv_value, MIN(size, nv_size));
+ if (size < nv_size)
+ return (-ERANGE);
+
+ memcpy(value, nv_value, size);
return (MIN(size, nv_size));
}
next prev parent reply other threads:[~2013-04-17 18:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <516E7D5C.7080309@nazarianin.com>
2013-04-17 15:19 ` test osd on zfs Sage Weil
2013-04-17 15:57 ` Henry C Chang
2013-04-17 16:37 ` Jeff Mitchell
2013-04-17 17:00 ` Henry C Chang
2013-04-17 17:00 ` Sage Weil
2013-04-17 17:04 ` Yehuda Sadeh
2013-04-17 17:05 ` Sage Weil
2013-04-17 17:15 ` Yehuda Sadeh
2013-04-17 18:06 ` Brian Behlendorf
2013-04-17 18:57 ` Brian Behlendorf [this message]
2013-04-17 19:07 ` Yehuda Sadeh
2013-04-17 19:09 ` Stefan Priebe
2013-04-17 20:16 ` Mark Nelson
2013-04-17 20:49 ` Jeff Mitchell
2013-04-17 21:14 ` Brian Behlendorf
2013-04-18 2:20 ` Henry C Chang
2013-04-18 5:56 ` Stefan Priebe - Profihost AG
2013-04-18 14:50 ` Sage Weil
2013-04-18 20:07 ` Alex Elsayed
2013-04-19 10:47 ` Jeff Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516EF07E.4000909@llnl.gov \
--to=behlendorf1@llnl.gov \
--cc=aleonov@nazarianin.com \
--cc=ceph-devel@vger.kernel.org \
--cc=henry.cy.chang@gmail.com \
--cc=jeffrey.mitchell@gmail.com \
--cc=sage@inktank.com \
--cc=yehuda@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.