[Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory

From: Jeff Liu <jeff.liu@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory
Date: Mon, 27 May 2013 14:53:49 +0800	[thread overview]
Message-ID: <51A302FD.1080801@oracle.com> (raw)
In-Reply-To: <519F06A0.8020404@oracle.com>

On 05/24/2013 02:20 PM, xiaowei.hu wrote:

> Should we also add this (status != -ENOTEMPTY) in end of ocfs2_rename?
> It also may hit this unecessary error.

This definitely is the same thing like ocfs2_unlink() that need to be fixed.

Thanks,
-Jeff

> 
> Thanks,
> xiaowei
> 
> On 05/20/2013 11:06 PM, Goldwyn Rodrigues wrote:
>> While removing a non-empty directory, the kernel dumps a message:
>> (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39
>>
>> Suppress the error message from being printed in the dmesg so users
>> don't panic.
>>
>> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>>
>> ---
>> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
>> index 04ee1b5..33c7b91 100644
>> --- a/fs/ocfs2/namei.c
>> +++ b/fs/ocfs2/namei.c
>> @@ -947,7 +947,7 @@ leave:
>>    ocfs2_free_dir_lookup_result(&orphan_insert);
>>    ocfs2_free_dir_lookup_result(&lookup);
>>
>> - if (status)
>> + if (status && (status != -ENOTEMPTY))
>>    mlog_errno(status);
>>
>>    return status;
>>
>> _______________________________________________
>> Ocfs2-devel mailing list
>> Ocfs2-devel at oss.oracle.com
>> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>>
>>
> 
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel