From: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
To: "Julien Isorce"
<julien.isorce-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Christian König"
<deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] [RFC] drm/radeon: clear WC flag when moving bo from vram to gtt
Date: Mon, 24 Apr 2017 19:08:47 +0900 [thread overview]
Message-ID: <51cf0681-5a4f-d245-27a8-e937cad18943@daenzer.net> (raw)
In-Reply-To: <CAHWPjbVvs70ucs69zC+6j-NyET1AWNFQ=JndKOqZRZA8v6m9+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 24/04/17 07:01 PM, Julien Isorce wrote:
>
> On 24 April 2017 at 10:51, Christian König <deathsimple@vodafone.de
> <mailto:deathsimple@vodafone.de>> wrote:
>
> Am 24.04.2017 um 11:42 schrieb Julien Isorce:
>
> But re-add the flag is the bo is moved back to vram.
>
> This fixes "ring 0/3 stalled" issue which happens when the driver
> evicts bo from vram to gtt, at least on TAHITI and CAPVERDE.
>
>
> Interesting find, but NAK on the approach for fixing it.
>
>
> Thx for the comments.
>
>
>
> If WC mappings don't work for TAHITI and CAPVERDE we need to figure
> out why or at least disable them for those hardware generations in
> general.
>
>
> Should I extend
> https://cgit.freedesktop.org/~agd5f/linux/tree/drivers/gpu/drm/radeon/radeon_object.c?h=amd-staging-4.9#n228
> to BONAIRE (which will include VERDE and TAHITI) ? (to match
> https://cgit.freedesktop.org/~agd5f/linux/tree/drivers/gpu/drm/radeon/radeon_ib.c?h=amd-staging-4.9#n199 )
Not sure the issue is widespread / systemic enough to justify that
upstream. You can do whatever you deem appropriate in your project, of
course.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-04-24 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 9:42 [PATCH] [RFC] drm/radeon: clear WC flag when moving bo from vram to gtt Julien Isorce
[not found] ` <1493026928-30134-1-git-send-email-jisorce-bXq66PvbRDbQT0dZR+AlfA@public.gmane.org>
2017-04-24 9:51 ` Christian König
[not found] ` <e602b898-ee7d-e744-5a08-0ab7d0f63d83-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-04-24 10:01 ` Julien Isorce
[not found] ` <CAHWPjbVvs70ucs69zC+6j-NyET1AWNFQ=JndKOqZRZA8v6m9+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-24 10:08 ` Michel Dänzer [this message]
2017-04-24 10:06 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51cf0681-5a4f-d245-27a8-e937cad18943@daenzer.net \
--to=michel-otuistvhuppr7s880joybq@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=julien.isorce-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.