From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rudi Heitbaum <rudi@heitbaum.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org,
marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, anarsoul@gmail.com, alistair@alistair23.me
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: allwinner: h6: tanix-tx6: Add compatible bluetooth
Date: Sun, 14 May 2023 11:55:42 +0200 [thread overview]
Message-ID: <51dbd824-7d90-8a69-902b-d643347abdf3@linaro.org> (raw)
In-Reply-To: <20230514074731.70614-4-rudi@heitbaum.com>
On 14/05/2023 09:47, Rudi Heitbaum wrote:
> Tanix TX6 comes either with RTL8822BS or RTL8822CS wifi+bt combo module.
> Add compatible for RTL8822BS as it uses different firmware.
>
> Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
> ---
Thank you for your patch. There is something to discuss/improve.
> arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> index 9a38ff9b3fc7..9460ccbc247d 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> @@ -21,7 +21,7 @@ &uart1 {
> status = "okay";
>
> bluetooth {
> - compatible = "realtek,rtl8822cs-bt";
> + compatible = "realtek,rtl8822bs-bt", "realtek,rtl8822cs-bt";
This neither matches bindings nor your commit msg. If device has
different chips, then you should not stuff all of compatibles together.
Please analyze the case. Maybe you need different boards for different
revisions?
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-14 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 7:47 [PATCH 0/3] Bluetooth: btrtl: Add support for RTL8822BS Rudi Heitbaum
2023-05-14 7:47 ` [PATCH 1/3] dt-bindings: net: realtek-bluetooth: Add RTL8822BS Rudi Heitbaum
2023-05-14 8:34 ` Bluetooth: btrtl: Add support for RTL8822BS bluez.test.bot
2023-05-14 9:51 ` [PATCH 1/3] dt-bindings: net: realtek-bluetooth: Add RTL8822BS Krzysztof Kozlowski
2023-05-14 9:53 ` Krzysztof Kozlowski
2023-05-14 7:47 ` [PATCH 2/3] Bluetooth: btrtl: Add support for RTL8822BS UART Rudi Heitbaum
2023-05-14 8:15 ` Christophe JAILLET
2023-05-14 9:14 ` kernel test robot
2023-05-14 9:44 ` kernel test robot
2023-05-14 11:05 ` kernel test robot
2023-05-14 7:47 ` [PATCH 3/3] arm64: dts: allwinner: h6: tanix-tx6: Add compatible bluetooth Rudi Heitbaum
2023-05-14 9:55 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51dbd824-7d90-8a69-902b-d643347abdf3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alistair@alistair23.me \
--cc=anarsoul@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jernej.skrabec@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rudi@heitbaum.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.