All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Subject: Re: [PATCH/RFC net-next 2/5] ravb: correct ptp does failure after suspend and resume
Date: Sat, 21 Apr 2018 23:33:48 +0300	[thread overview]
Message-ID: <51e8277c-5ac3-adc9-9daa-855bf4243468@cogentembedded.com> (raw)
In-Reply-To: <20180417085030.32650-3-horms+renesas@verge.net.au>

Hello!

   s/failure/fail/ in the subject.

On 04/17/2018 11:50 AM, Simon Horman wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> 
> This patch fixes the problem that ptp4l command does not work after
> suspend and resume.
> Add the initial setting in ravb_suspend() and ravb_resume(),
> because ptp does not work.
> 
> Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver")
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[...]

   Other than the earlier comments, this seems good:

Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei

  parent reply	other threads:[~2018-04-21 20:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17  8:50 [PATCH/RFC net-next 0/5] ravb: updates Simon Horman
2018-04-17  8:50 ` [PATCH/RFC net-next 1/5] ravb: fix inconsistent lock state at enabling tx timestamp Simon Horman
2018-04-17 10:07   ` Wolfram Sang
2018-04-17 13:11   ` Geert Uytterhoeven
2018-04-17 14:13   ` David Miller
2018-04-17  8:50 ` [PATCH/RFC net-next 2/5] ravb: correct ptp does failure after suspend and resume Simon Horman
2018-04-17 10:05   ` Wolfram Sang
2018-04-17 16:05     ` Sergei Shtylyov
2018-04-21 20:33   ` Sergei Shtylyov [this message]
2018-04-17  8:50 ` [PATCH/RFC net-next 3/5] ravb: do not write 1 to reserved bits Simon Horman
2018-04-17 14:15   ` David Miller
2018-04-21 20:44     ` Sergei Shtylyov
2018-04-21 20:53   ` Sergei Shtylyov
2018-04-17  8:50 ` [PATCH/RFC net-next 4/5] ravb: remove undocumented processing Simon Horman
2018-04-17 10:09   ` Wolfram Sang
2018-04-17 14:14   ` David Miller
2018-04-21 20:59   ` Sergei Shtylyov
2018-04-17  8:50 ` [PATCH/RFC net-next 5/5] ravb: remove tx buffer addr 4byte alilgnment restriction for R-Car Gen3 Simon Horman
2018-04-22 15:11   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51e8277c-5ac3-adc9-9daa-855bf4243468@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=horms+renesas@verge.net.au \
    --cc=kazuya.mizuguchi.ks@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.