From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Subject: Re: [PATCH 09/10] hw/ppc/mac.h: Move PROM and KERNEL defines to board code
Date: Sat, 17 Sep 2022 23:15:06 +0200 [thread overview]
Message-ID: <51f5218b-80be-5927-4bce-ddf0bf59c188@amsat.org> (raw)
In-Reply-To: <f8554a36947fc60caf104deffc6cfa5c4f244ae5.1663368422.git.balaton@eik.bme.hu>
On 17/9/22 01:07, BALATON Zoltan wrote:
> The PROM_FILENAME and KERNEL_* defines are used by mac_oldworld and
> mac_newworld but they don't have to be identical so these could be
> moved to the individual boards. The NVRAM_SIZE define is not used so
> it can be dropped. This further reduces the mac.h header.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/ppc/mac.h | 6 ------
> hw/ppc/mac_newworld.c | 4 ++++
> hw/ppc/mac_oldworld.c | 7 ++++++-
> 3 files changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-09-17 21:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 23:07 [PATCH 00/10] Misc ppc/mac machines clean up BALATON Zoltan
2022-09-16 23:07 ` [PATCH 01/10] mac_newworld: Drop some variables BALATON Zoltan
2022-09-17 21:05 ` Philippe Mathieu-Daudé via
2022-09-25 8:41 ` Mark Cave-Ayland
2022-09-16 23:07 ` [PATCH 02/10] mac_oldworld: Drop some more variables BALATON Zoltan
2022-09-17 21:06 ` Philippe Mathieu-Daudé via
2022-09-25 8:42 ` Mark Cave-Ayland
2022-09-16 23:07 ` [PATCH 03/10] mac_{old|new}world: Set default values for some local variables BALATON Zoltan
2022-09-25 8:48 ` Mark Cave-Ayland
2022-09-25 9:16 ` BALATON Zoltan
2022-09-25 9:41 ` BALATON Zoltan
2022-09-29 7:00 ` Mark Cave-Ayland
2022-10-03 22:08 ` BALATON Zoltan
2022-10-13 21:25 ` Mark Cave-Ayland
2022-09-16 23:07 ` [PATCH 04/10] mac_newworld: Simplify creation of Uninorth devices BALATON Zoltan
2022-09-25 8:57 ` Mark Cave-Ayland
2022-09-25 9:20 ` BALATON Zoltan
2022-09-16 23:07 ` [PATCH 05/10] mac_{old|new}world: Reduce number of QOM casts BALATON Zoltan
2022-09-17 21:13 ` Philippe Mathieu-Daudé via
2022-09-25 9:09 ` Mark Cave-Ayland
2022-09-16 23:07 ` [PATCH 06/10] hw/ppc/mac.h: Move newworld specific atuff out from shared header BALATON Zoltan
2022-09-25 9:13 ` Mark Cave-Ayland
2022-09-16 23:07 ` [PATCH 07/10] hw/ppc/mac.h: Move macio " BALATON Zoltan
2022-09-17 21:16 ` Philippe Mathieu-Daudé via
2022-09-17 21:17 ` Philippe Mathieu-Daudé via
2022-09-25 9:17 ` Mark Cave-Ayland
2022-09-25 9:23 ` BALATON Zoltan
2022-09-16 23:07 ` [PATCH 08/10] hw/ppc/mac.h: Move grackle-pcihost declaration " BALATON Zoltan
2022-09-25 9:21 ` Mark Cave-Ayland
2022-09-25 9:26 ` BALATON Zoltan
2022-09-29 7:07 ` Mark Cave-Ayland
2022-09-16 23:07 ` [PATCH 09/10] hw/ppc/mac.h: Move PROM and KERNEL defines to board code BALATON Zoltan
2022-09-17 21:15 ` Philippe Mathieu-Daudé via [this message]
2022-09-25 9:22 ` Mark Cave-Ayland
2022-09-16 23:07 ` [PATCH 10/10] hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h BALATON Zoltan
2022-09-25 9:23 ` Mark Cave-Ayland
2022-09-24 13:09 ` [PATCH 00/10] Misc ppc/mac machines clean up BALATON Zoltan
2022-09-24 16:20 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51f5218b-80be-5927-4bce-ddf0bf59c188@amsat.org \
--to=qemu-devel@nongnu.org \
--cc=balaton@eik.bme.hu \
--cc=f4bug@amsat.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.