From: Yijing Wang <wangyijing@huawei.com>
To: Li Zefan <lizefan@huawei.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
Hanjun Guo <guohanjun@huawei.com>, <jiang.liu@huawei.com>,
Jon Mason <jdmason@kudzu.us>, <stable@vger.kernel.org>
Subject: Re: [PATCH -v2] PCI: update device mps when doing pci hotplug
Date: Tue, 6 Aug 2013 16:04:07 +0800 [thread overview]
Message-ID: <5200ADF7.80006@huawei.com> (raw)
In-Reply-To: <5200A7D2.3080001@huawei.com>
On 2013/8/6 15:37, Li Zefan wrote:
> On 2013/8/6 15:23, Yijing Wang wrote:
>> v1->v2: Update patch log, remove Joe's reported-by, because his problem
>> was mainly caused by BIOS incorrect setting. But this patch mainly
>> to fix the bug caused by device hot add. Conservatively, this
>> version only update the mps problem when hot add. When the device
>> mps < parent mps found, this patch try to update device mps.
>> It seems unlikely device mps > parent mps after hot add device.
>> So we don't care that situation.
>>
>> This patch need to be applied to stable 3.4+
>
> In this case...
>
>>
>> Currently we don't update device's mps vaule when doing
>> pci device hot-add. The hot-added device's mps will be set
>> to default value (128B). But the upstream port device's mps
>> may be larger than 128B which was set by firmware during
>> system bootup. In this case the new added device may not
>> work normally. This patch try to update the hot added device
>> mps euqal to its parent mps, if device mpss < parent mps,
>> print warning.
>>
>> References: https://bugzilla.kernel.org/show_bug.cgi?id=60671
>> Reported-by: Yijing Wang <wangyijing@huawei.com>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> Cc: Jon Mason <jdmason@kudzu.us>
>> Cc: stable@vger.kernel.org
>
> The better tag is:
>
> Cc: <stable@vger.kernel.org> # 3.4+
>
> Otherwise you won't be notified if it can be applied to the most recent
> stable version but failed in older versions.
Will update, thanks!
>
>
> .
>
--
Thanks!
Yijing
prev parent reply other threads:[~2013-08-06 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 7:23 [PATCH -v2] PCI: update device mps when doing pci hotplug Yijing Wang
2013-08-06 7:37 ` Li Zefan
2013-08-06 8:04 ` Yijing Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5200ADF7.80006@huawei.com \
--to=wangyijing@huawei.com \
--cc=bhelgaas@google.com \
--cc=guohanjun@huawei.com \
--cc=jdmason@kudzu.us \
--cc=jiang.liu@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.