Re: [PATCH 2/3] Btrfs: rework qgroup accounting

From: Josef Bacik <jbacik@fb.com>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/3] Btrfs: rework qgroup accounting
Date: Sat, 21 Dec 2013 09:13:35 -0500	[thread overview]
Message-ID: <52B5A20F.1050008@fb.com> (raw)
In-Reply-To: <D8610409-5BF3-4150-A0DF-DC9985169540@gmail.com>

On 12/21/2013 03:01 AM, Wang Shilong wrote:
> Hi Josef,
>
> I compie btrfs-next in my 32-bit machine, i get the following warnings:
>
> fs/btrfs/qgroup.c: In function ‘qgroup_excl_accounting’:
> fs/btrfs/qgroup.c:1503:12: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    qgroup = (struct btrfs_qgroup *)unode->aux;
>             ^
> fs/btrfs/qgroup.c: In function ‘qgroup_calc_old_refcnt’:
> fs/btrfs/qgroup.c:1571:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     qg = (struct btrfs_qgroup *)tmp_unode->aux;
>          ^
> fs/btrfs/qgroup.c: In function ‘qgroup_account_deleted_refs’:
> fs/btrfs/qgroup.c:1665:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    qg = (struct btrfs_qgroup *)unode->aux;
>         ^
> fs/btrfs/qgroup.c: In function ‘qgroup_calc_new_refcnt’:
> fs/btrfs/qgroup.c:1705:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    qg = (struct btrfs_qgroup *)unode->aux;
>         ^
> fs/btrfs/qgroup.c: In function ‘qgroup_adjust_counters’:
> fs/btrfs/qgroup.c:1767:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    qg = (struct btrfs_qgroup *)unode->aux;
>
> this patch is newly added into btrfs-next, so i think it is better that you fix these warnings locally .^_^

Crap I fixed part of these but not the other part, I'll fix it up and
push it out Monday. Thanks,

Josef