Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data

From: Stephen Boyd <sboyd@codeaurora.org>
To: balbi@ti.com, "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: gregkh@linuxfoundation.org, rob.herring@calxeda.com,
	pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org,
	ijc+devicetree@hellion.org.uk, davidb@codeaurora.org,
	linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Daniel Walker <dwalker@fifo99.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data
Date: Fri, 27 Dec 2013 10:23:10 -0800	[thread overview]
Message-ID: <52BDC58E.2040101@codeaurora.org> (raw)
In-Reply-To: <20131227181009.GF7819@saruman.home>

On 12/27/13 10:10, Felipe Balbi wrote:
> Hi,
>
> On Tue, Nov 12, 2013 at 04:51:36PM +0200, Ivan T. Ivanov wrote:
>> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>>
>> This patch fix compilation error when driver is compiled
>> in multi-platform builds.
>>
>> drivers/built-in.o: In function `msm_otg_link_clk_reset':
>> ./drivers/usb/phy/phy-msm-usb.c:314: undefined reference to `clk_reset'
>> ./drivers/usb/phy/phy-msm-usb.c:318: undefined reference to `clk_reset'
>>
>> Use platform data supplied reset handlers and adjust error
>> messages reported when reset sequence fail.
>>
>> This is an intermediate step before adding support for reset
>> framework and newer targets.
>>
>> Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
>> Acked-by: David Brown <davidb@codeaurora.org>
>> Cc: Daniel Walker <dwalker@fifo99.com>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> this really looks like you should be using reset framework
> (drivers/reset/), then your phy driver would simply reset_assert() and
> reset_deassert().
>

Unfortunately the reset framework is a DT only framework and there are
still non-DT platforms within mach-msm. Arnd suggested we push the
non-DT reset code down into the mach directory in the meantime. We're in
the process of adding the reset framework to DT enabled MSM platforms,
hopefully those get merged in 3.14.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation