From: Clemens Ladisch <clemens@ladisch.de>
To: Mario Kicherer <dev@kicherer.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v6] MIDI driver for Behringer BCD2000 USB device
Date: Mon, 24 Feb 2014 21:39:11 +0100 [thread overview]
Message-ID: <530BADEF.5040806@ladisch.de> (raw)
In-Reply-To: <530BA60E.9000408@kicherer.org>
Mario Kicherer wrote:
> On 23.02.2014 21:24, Clemens Ladisch wrote:
>>> +static void bcd2000_input_complete(struct urb *urb)
>>> +{
>>> + if (urb->status) {
>>> + dev_warn(dev, PREFIX "input urb->status: %i\n", urb->status);
>>> + return;
>>> + }
>>
>> This will stop the input even on transient errors.
>
> Hm, so, it is important to send the "acknowledge" urb afterwards
> nonetheless?
This has nothing to do with acknowledging. Once the completion callback
was called, the URB is again owned by your driver, and nothing happens
unless you submit it again.
The only reason not to re-submit the URB is a permanent error (i.e., if
the device has been unplugged).
> Do you actually own a BCD2000?
Yes.
Regards,
Clemens
prev parent reply other threads:[~2014-02-24 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 15:11 [PATCH v6] MIDI driver for Behringer BCD2000 USB device Mario Kicherer
2014-02-23 20:24 ` Clemens Ladisch
2014-02-24 20:05 ` Mario Kicherer
2014-02-24 20:39 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530BADEF.5040806@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=dev@kicherer.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.