All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Richard Leitner <richard.leitner@skidata.com>
Cc: mark.rutland@arm.com, robh+dt@kernel.org,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 8/8] Input: sx8654 - convert #defined flags to BIT(x)
Date: Mon, 28 Jan 2019 21:40:54 -0800	[thread overview]
Message-ID: <533e48bd35d360cec8d749f3b70425c1eb5e6e9d.camel@perches.com> (raw)
In-Reply-To: <20190129002518.GH34692@dtor-ws>

On Mon, 2019-01-28 at 16:25 -0800, Dmitry Torokhov wrote:
> On Tue, Dec 18, 2018 at 09:40:02AM +0100, Richard Leitner wrote:
> > Some of the #defined register values are one-bit flags. Convert them to
> > use the BIT(x) macro instead of 1 byte hexadecimal values. This improves
> > readability and clarifies the intent.
> > 
> > Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> 
> Applied, thank you.

Not so sure this should be applied.

> > diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
[]
> > @@ -46,7 +47,7 @@
[]
> >  /* bits for I2C_REG_IRQSRC */
> > -#define IRQ_PENTOUCH_TOUCHCONVDONE	0x08
> > -#define IRQ_PENRELEASE			0x04
> > +#define IRQ_PENTOUCH_TOUCHCONVDONE	BIT(7)
> > +#define IRQ_PENRELEASE			BIT(6)

Shouldn't this be BIT(3) and BIT(2)
or did you mean to change the values too?

If so, this change should be noted in the commit message.


  reply	other threads:[~2019-01-29  5:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18  8:35 [RESEND PATCH v2 0/8] Input: sx8654 - reset-gpio, sx865[056] support, etc Richard Leitner
2018-12-18  8:35 ` Richard Leitner
2018-12-18  8:35 ` [RESEND PATCH v2 1/8] dt-bindings: input: touchscreen: sx8654: add reset-gpio property Richard Leitner
2018-12-18  8:35   ` Richard Leitner
2018-12-18  8:36 ` [RESEND PATCH v2 2/8] Input: sx8654 - add reset-gpio support Richard Leitner
2018-12-18  8:36   ` Richard Leitner
2019-01-29  0:26   ` Dmitry Torokhov
2018-12-18  8:36 ` [RESEND PATCH v2 3/8] dt-bindings: input: touchscreen: sx8654: add compatible models Richard Leitner
2018-12-18  8:36   ` Richard Leitner
2018-12-18  8:36 ` [RESEND PATCH v2 4/8] Input: sx8654 - add sx8655 and sx8656 to compatibles Richard Leitner
2018-12-18  8:36   ` Richard Leitner
2019-01-29  0:26   ` Dmitry Torokhov
2018-12-18  8:39 ` [RESEND PATCH v2 5/8] dt-bindings: input: touchscreen: sx8654: add sx8650 to comatibles Richard Leitner
2018-12-18  8:39   ` Richard Leitner
2018-12-18  8:39 ` [RESEND PATCH v2 6/8] Input: sx8654 - add sx8650 support Richard Leitner
2018-12-18  8:39   ` Richard Leitner
2019-01-29  0:12   ` Dmitry Torokhov
2018-12-18  8:39 ` [RESEND PATCH v2 7/8] Input: sx8654 - use common of_touchscreen functions Richard Leitner
2018-12-18  8:39   ` Richard Leitner
2019-01-29  0:25   ` Dmitry Torokhov
2018-12-18  8:40 ` [RESEND PATCH v2 8/8] Input: sx8654 - convert #defined flags to BIT(x) Richard Leitner
2018-12-18  8:40   ` Richard Leitner
2019-01-29  0:25   ` Dmitry Torokhov
2019-01-29  5:40     ` Joe Perches [this message]
2019-01-29 11:23       ` Richard Leitner
2019-01-29 11:23         ` Richard Leitner
2019-02-05  7:27         ` Dmitry Torokhov
2019-01-03 10:08 ` [RESEND PATCH v2 0/8] Input: sx8654 - reset-gpio, sx865[056] support, etc Richard Leitner
2019-01-03 10:08   ` Richard Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533e48bd35d360cec8d749f3b70425c1eb5e6e9d.camel@perches.com \
    --to=joe@perches.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=richard.leitner@skidata.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.