From: "H. Peter Anvin" <hpa@zytor.com>
To: George Spelvin <linux@horizon.com>, pavel@ucw.cz
Cc: arik@wizery.com, david.gnedt@davizone.at, eliad@wizery.com,
jan.nikitenko@gmail.com,
laurent.pinchart+renesas@ideasonboard.com,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-spi@vger.kernel.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, luca@coelho.fi, tony@atomide.com
Subject: Re: [PATCH v2 1/3] lib/crc7: Shift crc7() output left 1 bit
Date: Wed, 14 May 2014 17:37:22 -0700 [thread overview]
Message-ID: <53740C42.3000906@zytor.com> (raw)
In-Reply-To: <20140511100211.1334.qmail@ns.horizon.com>
On 05/11/2014 03:02 AM, George Spelvin wrote:
> From 770aa22e6c9c92027e3e21797192ccabb3e7c70e Mon Sep 17 00:00:00 2001
> From: George Spelvin <linux@horizon.com>
> Date: Sat, 10 May 2014 10:32:57 -0400
> Subject: [PATCH v2 1/3] lib/crc7: Shift crc7() output left 1 bit
>
> This eliminates a 1-bit left shift in every single caller,
> and makes the inner loop of the CRC computation more efficient.
>
> Renamed crc7 to crc7_be (big-endian) since the interface changed.
>
> Also purged #include <linux/crc7.h> from files that don't use it at all.
>
> Signed-off-by: George Spelvin <linux@horizon.com>
If the whole point of this is to use it for MMC/SD cards, why not just
also subsume the OR 1 and call it crc7_mmc() or something like that.
(Which I'm all for doing... I don't know of any other crc7 users.)
-hpa
next prev parent reply other threads:[~2014-05-15 0:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 4:35 [PATCH] lib/crc7: Shift crc7() output left 1 bit George Spelvin
2014-05-11 8:28 ` Pavel Machek
2014-05-11 9:16 ` George Spelvin
2014-05-14 19:56 ` Pavel Machek
2014-05-15 0:32 ` George Spelvin
2014-05-15 6:06 ` Pavel Machek
2014-05-11 10:02 ` [PATCH v2 1/3] " George Spelvin
2014-05-11 10:05 ` [PATCH 2/3] drivers/mmc/host/mmc_spi.c: Use get/put_unaligned_be32 George Spelvin
2014-05-11 10:05 ` George Spelvin
2014-05-11 10:33 ` Pavel Machek
2014-05-11 10:33 ` Pavel Machek
2014-05-12 8:05 ` Geert Uytterhoeven
2014-05-14 10:17 ` Ulf Hansson
2014-05-14 10:17 ` Ulf Hansson
2014-05-14 12:23 ` George Spelvin
2014-05-14 12:30 ` Ulf Hansson
2014-05-14 12:30 ` Ulf Hansson
2014-05-14 14:50 ` John W. Linville
2014-05-11 10:07 ` [PATCH 3/3] drivers/net/wireless/ti/wl*/spi.c: Simplify CRC computation George Spelvin
2014-05-11 10:07 ` George Spelvin
2014-05-11 10:36 ` Pavel Machek
2014-05-11 10:36 ` Pavel Machek
2014-05-11 10:32 ` [PATCH v2 1/3] lib/crc7: Shift crc7() output left 1 bit Pavel Machek
2014-05-14 10:14 ` Ulf Hansson
2014-05-15 0:37 ` H. Peter Anvin [this message]
2014-05-15 1:15 ` George Spelvin
2014-05-15 1:26 ` H. Peter Anvin
2014-05-15 2:02 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53740C42.3000906@zytor.com \
--to=hpa@zytor.com \
--cc=arik@wizery.com \
--cc=david.gnedt@davizone.at \
--cc=eliad@wizery.com \
--cc=jan.nikitenko@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@horizon.com \
--cc=linville@tuxdriver.com \
--cc=luca@coelho.fi \
--cc=pavel@ucw.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.