From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: <dsterba@suse.cz>, Wang Shilong <wangsl.fnst@cn.fujitsu.com>,
<linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] Btrfs: clear compress-force when remounting with compress option
Date: Wed, 2 Jul 2014 10:58:46 +0900 [thread overview]
Message-ID: <53B36756.5030601@jp.fujitsu.com> (raw)
In-Reply-To: <20140701160457.GM1553@twin.jikos.cz>
(2014/07/02 1:04), David Sterba wrote:
> On Mon, Jun 30, 2014 at 10:51:25AM +0800, Wang Shilong wrote:
>> Steps to reproduce:
>> # mkfs.btrfs -f /dev/sdb
>> # mount /dev/sdb /mnt -o compress-force=lzo
>> # mount /dev/sdb /mnt -o remount,compress=zlib
>> # cat /proc/mounts
>>
>> Remounting from compress-force to compress could not clear compress-force
>> option. The problem is there is no way for users to clear compress-force
>> option separately.
>>
>> Fix this problem by clearing @FORCE_COMPRESS flag when remounting to
>> compress=xxx.
>>
>> Suggested-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
>> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
>
> I'm sorry for lack of answer in the V1 thread, V2 is the minimal bugfix
> and I'm fine with it right away.
>
> Reviewed-by: David Sterba <dsterba@suse.cz>
Test result (I used your reproducer):
3.16-rc3: FAIL
3.16-rc3 w/ your patch: PASS
Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Tested-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Thanks,
Satoru
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-07-02 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 2:51 [PATCH v2] Btrfs: clear compress-force when remounting with compress option Wang Shilong
2014-07-01 16:04 ` David Sterba
2014-07-02 1:58 ` Satoru Takeuchi [this message]
2014-07-02 2:21 ` Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B36756.5030601@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangsl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.