Re: [PATCH v5 2/5] ASoC: pcm: Add support for DAI multicodec

From: Benoit Cousson <bcousson@baylibre.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
	broonie@kernel.org, lgirdwood@gmail.com
Cc: Fabien Parent <fparent@baylibre.com>,
	misael.lopez@ti.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH v5 2/5] ASoC: pcm: Add support for DAI multicodec
Date: Sun, 06 Jul 2014 22:23:10 +0200	[thread overview]
Message-ID: <53B9B02E.1050203@baylibre.com> (raw)
In-Reply-To: <53B95AB0.8070307@metafoo.de>

On 06/07/2014 16:18, Lars-Peter Clausen wrote:
> On 07/04/2014 06:07 PM, Benoit Cousson wrote:
> [...]
>>    */
>>   bool snd_soc_runtime_ignore_pmdown_time(struct snd_soc_pcm_runtime
>> *rtd)
>>   {
>> +    int i;
>> +    bool ignore = true;
>> +
>>       if (!rtd->pmdown_time || rtd->dai_link->ignore_pmdown_time)
>>           return true;
>>
>> -    return rtd->cpu_dai->component->ignore_pmdown_time &&
>> -            rtd->codec_dai->component->ignore_pmdown_time;
>> +    for (i = 0; (i < rtd->num_codecs) && !ignore; i++)
>
> As you said last time this should be '&& ignore'. Or maybe just drop the
> check altogether.

Oops, I forgot to fix it before posting :-(

I guess I'll drop it, it is a little bit overkill.

Thanks,
Benoit

-- 
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com