Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected - Lars-Peter Clausen

From: Lars-Peter Clausen <lars@metafoo.de>
To: pramod.gurav.etc@gmail.com, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Cc: Josh Cartwright <joshc@codeaurora.org>, Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected
Date: Wed, 16 Jul 2014 14:19:47 +0200	[thread overview]
Message-ID: <53C66DE3.5080502@metafoo.de> (raw)
In-Reply-To: <1405510797-755-1-git-send-email-pramod.gurav.etc@gmail.com>

On 07/16/2014 01:39 PM, pramod.gurav.etc@gmail.com wrote:
> From: Pramod Gurav <pramod.gurav.etc@gmail.com>
>
> REGMAP_SPMI module calls some functions from SPMI hence build breaks
> when SPMI is not enabled while compiling REGMAP_SPMI with below linker
> errors:
>
> drivers/built-in.o: In function `regmap_spmi_ext_read':
> :(.text+0x1143ec): undefined reference to `spmi_ext_register_read'
> :(.text+0x11443c): undefined reference to `spmi_ext_register_readl'
> drivers/built-in.o: In function `regmap_spmi_ext_gather_write':
> :(.text+0x1144c4): undefined reference to `spmi_ext_register_write'
> :(.text+0x114520): undefined reference to `spmi_ext_register_writel'
> drivers/built-in.o: In function `regmap_spmi_base_read':
> :(.text+0x1145b8): undefined reference to `spmi_register_read'
> drivers/built-in.o: In function `regmap_spmi_base_gather_write':
> :(.text+0x114630): undefined reference to `spmi_register_write'
> :(.text+0x11465c): undefined reference to `spmi_register_zero_write'
>
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
> CC: Josh Cartwright <joshc@codeaurora.org>
> CC: Mark Brown <broonie@linaro.org>
> ---
> This was found when I enabled support for Qualcomm QPNP PMICs and was
> compiling it. It selects REGMAP_SPMI and hence the crash.

Any driver that does select REGMAP_SPMI needs to depends on SPMI. So the 
correct fix for this issue is to make sure that the driver can only be 
enabled if SPMI is enabled.

- Lars