All of lore.kernel.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/11] KVM: vgic: declare probe function pointer as const
Date: Tue, 26 Aug 2014 15:27:36 +0100	[thread overview]
Message-ID: <53FC9958.9010907@arm.com> (raw)
In-Reply-To: <1409062410-25891-7-git-send-email-will.deacon@arm.com>

On 26/08/14 15:13, Will Deacon wrote:
> We extract the vgic probe function from the of_device_id data pointer,
> which is const. Kill the sparse warning by ensuring that the local
> function pointer is also marked as const.
> 
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.

> ---
>  virt/kvm/arm/vgic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
> index d1cfe672b9d7..efe6eee2e7eb 100644
> --- a/virt/kvm/arm/vgic.c
> +++ b/virt/kvm/arm/vgic.c
> @@ -1557,8 +1557,8 @@ static const struct of_device_id vgic_ids[] = {
>  int kvm_vgic_hyp_init(void)
>  {
>  	const struct of_device_id *matched_id;
> -	int (*vgic_probe)(struct device_node *,const struct vgic_ops **,
> -			  const struct vgic_params **);
> +	const int (*vgic_probe)(struct device_node *,const struct vgic_ops **,
> +				const struct vgic_params **);
>  	struct device_node *vgic_node;
>  	int ret;
>  
> 


-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2014-08-26 14:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 14:13 [PATCH 00/11] Fix arm64 issues highlighted by sparse and smatch Will Deacon
2014-08-26 14:13 ` [PATCH 01/11] KVM: ARM/arm64: fix non-const declaration of function returning const Will Deacon
2014-08-26 14:21   ` Marc Zyngier
2014-08-26 14:29   ` Christoffer Dall
2014-08-26 14:13 ` [PATCH 02/11] KVM: ARM/arm64: fix broken __percpu annotation Will Deacon
2014-08-26 14:21   ` Marc Zyngier
2014-08-26 14:13 ` [PATCH 03/11] KVM: ARM/arm64: avoid returning negative error code as bool Will Deacon
2014-08-26 14:22   ` Marc Zyngier
2014-08-26 14:49   ` Christoffer Dall
2014-08-26 14:13 ` [PATCH 04/11] KVM: ARM/arm64: return -EFAULT if copy_from_user fails in set_timer_reg Will Deacon
2014-08-26 14:22   ` Marc Zyngier
2014-08-26 14:49   ` Christoffer Dall
2014-08-26 14:13 ` [PATCH 05/11] KVM: vgic: return int instead of bool when checking I/O ranges Will Deacon
2014-08-26 14:27   ` Marc Zyngier
2014-08-26 14:49   ` Christoffer Dall
2014-08-26 14:13 ` [PATCH 06/11] KVM: vgic: declare probe function pointer as const Will Deacon
2014-08-26 14:27   ` Marc Zyngier [this message]
2014-08-26 14:50   ` Christoffer Dall
2014-08-26 14:13 ` [PATCH 07/11] irqchip: gic: make gic_default_routable_irq_domain_ops static Will Deacon
2014-08-26 14:29   ` Marc Zyngier
2014-08-26 14:13 ` [PATCH 08/11] irqchip: gic-v3: declare rdist as __percpu pointer to __iomem pointer Will Deacon
2014-08-26 14:29   ` Marc Zyngier
2014-08-26 14:13 ` [PATCH 09/11] arm64: ptrace: fix compat hardware watchpoint reporting Will Deacon
2014-08-26 14:13 ` [PATCH 10/11] arm64: ptrace: fix compat reg getter/setter return values Will Deacon
2014-08-26 14:13 ` [PATCH 11/11] arm64: perf: don't rely on layout of pt_regs when grabbing sp or pc Will Deacon
2014-08-26 14:43   ` Jean Pihet
2014-08-26 14:56 ` [PATCH 00/11] Fix arm64 issues highlighted by sparse and smatch Christoffer Dall
2014-08-26 17:05   ` Will Deacon
2014-08-27 20:58     ` Christoffer Dall
2014-09-03 12:10 ` Jason Cooper
     [not found] <540C32A8.1000409@linaro.org>
2014-09-07 10:34 ` [PATCH 06/11] KVM: vgic: declare probe function pointer as const Ard Biesheuvel
2014-09-08 11:03   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FC9958.9010907@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.