From: Eric Sandeen <sandeen@sandeen.net>
To: Bill O'Donnell <billodo@redhat.com>, linux-xfs@vger.kernel.org
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfsprogs: populate fs table with xfs entries first, foreign entries last
Date: Wed, 14 Sep 2016 14:54:27 -0500 [thread overview]
Message-ID: <53e9e6c0-c83e-d681-f021-83c97cccbfb6@sandeen.net> (raw)
In-Reply-To: <b49366ac-d277-a26f-1936-8e736d1c913c@sandeen.net>
On 9/14/16 12:50 PM, Eric Sandeen wrote:
>> @@ -113,8 +119,13 @@ path_f(
> Oops, I mentioned this to you as needed, but it's wrong, sorry.
>
> Just drop this hunk, this is supposed to select path i, not iterate
> over anything. Sorry for mentioning it.
>
>> > printf(_("value %d is out of range (0-%d)\n"),
>> > i, fs_count-1);
>> > } else {
>> > - fs_path = &fs_table[i];
>> > - pathlist_f();
>> > + for (i = 0; i < fs_count; i++) {
>> > + fs_path = &fs_table[i];
>> > + /* Table is ordered xfs first, then foreign */
>> > + if (fs_path->fs_flags & FS_FOREIGN && !foreign_allowed)
>> > + break;
>> > + pathlist_f();
>> > + }
>> > }
>> > return 0;
>> > }
Oh, right. You need the test & break in print_f not path_f, otherwise:
# quota/xfs_quota -x
xfs_quota> print
Filesystem Pathname
/home /dev/mapper/vg_bp05-lv_home
/mnt/test2 /dev/sdc1
(F) / /dev/mapper/vg_bp05-lv_root
(F) /boot /dev/sda1
(F) /mnt/test /dev/sdb1
xfs_quota>
"print" gives you foreign filesystems when you didn't ask for them.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-09-14 19:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 15:19 [PATCH 0/3] xfsprogs: xfs_quota foreign fs path handling modifications Bill O'Donnell
2016-09-14 15:19 ` [PATCH 1/3] xfsprogs: populate fs table with xfs entries first, foreign entries last Bill O'Donnell
2016-09-14 17:50 ` Eric Sandeen
2016-09-14 19:54 ` Eric Sandeen [this message]
2016-09-14 15:19 ` [PATCH 2/3] xfs_quota: print and path output formatting: maintain reverse compatibility Bill O'Donnell
2016-09-14 22:14 ` Eric Sandeen
2016-09-14 15:19 ` [PATCH 3/3] xfs_quota: add case for foreign fs, disabled regardless of foreign_allowed Bill O'Donnell
2016-09-15 15:29 ` [PATCH v2 0/3] xfsprogs: xfs_quota foreign fs path handling modifications Bill O'Donnell
2016-09-15 15:29 ` [PATCH v2 1/3] xfsprogs: populate fs table with xfs entries first, foreign entries last Bill O'Donnell
2016-09-15 19:26 ` Eric Sandeen
2016-09-15 15:29 ` [PATCH v2 2/3] xfs_quota: print and path output formatting: maintain reverse compatibility Bill O'Donnell
2016-09-15 19:27 ` Eric Sandeen
2016-09-15 15:29 ` [PATCH v2 3/3] xfs_quota: add case for foreign fs, disabled regardless of foreign_allowed Bill O'Donnell
2016-09-15 19:32 ` Eric Sandeen
2016-09-15 19:57 ` [PATCH v3 " Bill O'Donnell
2016-09-15 20:43 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53e9e6c0-c83e-d681-f021-83c97cccbfb6@sandeen.net \
--to=sandeen@sandeen.net \
--cc=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.