Re: [PATCHv2 0/8] Upstreaming the Android build and misc fixes

From: Emil Velikov <emil.l.velikov@gmail.com>
To: "Gore, Tim" <tim.gore@intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCHv2 0/8] Upstreaming the Android build and misc fixes
Date: Fri, 29 Aug 2014 11:02:53 +0100	[thread overview]
Message-ID: <54004FCD.8060701@gmail.com> (raw)
In-Reply-To: <8FCC70911F3E9548866CA0E51893BCC31A201CE2@IRSMSX105.ger.corp.intel.com>

Hi Tim,

On 29/08/14 10:44, Gore, Tim wrote:
> Hi Emil, sorry for the delay.
> I still see the same patch error for patch 3/8. The patch diff
> for intel/makefile.am has as part of its context:
> 
> #    Eric Anholt <eric at anholt.net>
> 
> Whereas the source file has
> 
> #    Eric Anholt <eric@anholt.net>
> 
> So the patch fails. Its trivial of course. Perhaps there is some automatic
> Substitution getting done by some tool.
The issue you're seeing here is (afaik) an anti-spam feature. The ML
software/parser automatically substitutes/obscures email addresses.

For any future case, I would recommend adding a remote branch rather than
picking patches from mailling-lists - not all of them play nice :\

> Maybe git-am will automatically
> Fix this, not sure, I don't have a workflow for git-am.
> My source comes from
>    Git://anongit.freedesktop.org/git/mesa/drm
> Remote =origin
> Merge = refs/heads/master
> 
> Other than that, as I say the patches look fine, and I have successfully built
> Libdrm in an Android tree using these patches and "mm".
> I am out of the office from 12:00 until Thurs 4th Sept now.
> 
Nice. They build fine on my end as well. I've even had a couple of people test
them (with a mmap patch on top) alongside mesa 10.2 :)

I was hoping for an acked-by/reviewed-by, but it seems like I'll push the
series as is.

Thanks
Emil

>   Tim
> 